Re: [PATCH] floppy: remove redundant assignment to variable st

2021-04-16 Thread Jens Axboe
On 4/16/21 6:29 AM, Denis Efremov wrote: > Jens, could you please take this one? I thought to send it to you with other > cleanup patches in a merge request, but you already applied rest of the > patches. If you prefer to take it as merge request, it's ok I'll send it > based on your branch for-5.1

Re: [PATCH] floppy: remove redundant assignment to variable st

2021-04-16 Thread Denis Efremov
Jens, could you please take this one? I thought to send it to you with other cleanup patches in a merge request, but you already applied rest of the patches. If you prefer to take it as merge request, it's ok I'll send it based on your branch for-5.13/drivers. On 4/15/21 4:00 PM, Colin King wrote:

Re: [PATCH] floppy: remove redundant assignment to variable st

2021-04-16 Thread Denis Efremov
Hi, On 4/15/21 4:00 PM, Colin King wrote: > From: Colin Ian King > > The variable st is being assigned a value that is never read and > it is being updated later with a new value. The initialization is > redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Col

Re: [PATCH] floppy: remove redundant assignment to variable st

2021-04-15 Thread Willy Tarreau
On Thu, Apr 15, 2021 at 02:00:20PM +0100, Colin King wrote: > From: Colin Ian King > > The variable st is being assigned a value that is never read and > it is being updated later with a new value. The initialization is > redundant and can be removed. > > Addresses-Coverity: ("Unused value") > S

[PATCH] floppy: remove redundant assignment to variable st

2021-04-15 Thread Colin King
From: Colin Ian King The variable st is being assigned a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King --- arch/x86/include/asm/floppy.h | 1 - 1 fi