Re: [PATCH] fix wait_task_inactive race (was Re: Race condition in ptrace)

2005-02-14 Thread Bodo Stroesser
Nick Piggin wrote: Your one liner would fix the problem too, of course. The important thing at this stage is that it gets fixed for 2.6.11. Sorry, have been off the net last week. Thank you for the patches. Have tested Ingo's one liner. It works fine for me, as expected. Bodo - To unsubscribe from

Re: [PATCH] fix wait_task_inactive race (was Re: Race condition in ptrace)

2005-02-05 Thread Nick Piggin
Nick Piggin wrote: Ingo Molnar wrote: * Nick Piggin <[EMAIL PROTECTED]> wrote: When a task is put to sleep, it is dequeued from the runqueue while it is still running. The problem is that the runqueue lock can be dropped and retaken in schedule() before the task actually schedules off, and wait_ta

Re: [PATCH] fix wait_task_inactive race (was Re: Race condition in ptrace)

2005-02-05 Thread Nick Piggin
Ingo Molnar wrote: * Nick Piggin <[EMAIL PROTECTED]> wrote: When a task is put to sleep, it is dequeued from the runqueue while it is still running. The problem is that the runqueue lock can be dropped and retaken in schedule() before the task actually schedules off, and wait_task_inactive did not

Re: [PATCH] fix wait_task_inactive race (was Re: Race condition in ptrace)

2005-02-05 Thread Ingo Molnar
* Nick Piggin <[EMAIL PROTECTED]> wrote: > When a task is put to sleep, it is dequeued from the runqueue > while it is still running. The problem is that the runqueue > lock can be dropped and retaken in schedule() before the task > actually schedules off, and wait_task_inactive did not account >

[PATCH] fix wait_task_inactive race (was Re: Race condition in ptrace)

2005-02-05 Thread Nick Piggin
Nick Piggin wrote: Something like the following (untested) extension of Bodo's work could be the minimal fix for 2.6.11. As I've said though, I'd consider it a hack and prefer to do something about the locking. That could be done after 2.6.11 though. Depends how you feel. I think this is the right