Re: [PATCH] fix units/partition count in sd.c (2.4.x)

2005-02-26 Thread Soo Lee
Thanks for your attention. I think It only matters when there're many scsi controllers but less disks like one disk per controller. Even in such case The main user of nr_real does genhd.c:part_show() /* show the full disk and all non-0 size partitions of it */ for (n = 0; n < (gp

Re: [PATCH] fix units/partition count in sd.c (2.4.x)

2005-02-26 Thread Marcelo Tosatti
On Wed, Feb 16, 2005 at 11:23:53AM -0500, Luben Tuikov wrote: > Hi, > > This patch fixes the nr_real count in sd.c, which is also used > in genhd.c to print out the partitions/units. The problem is that > nr_real is decremented on detach, the genhd's nr_sects is > cleared but the entry is still t

Re: [PATCH] fix units/partition count in sd.c (2.4.x)

2005-02-16 Thread soohoon . lee
Conincidentally I've found the same problem but fixed it differently. Because nr_real is not real # of devices but max # of devices of a major #, it doesn't need to be changed on disk add/remove. 1223c1223 < sd_gendisks[i].nr_real = 0; --- > sd_gendisks[i].nr_real = SC

[PATCH] fix units/partition count in sd.c (2.4.x)

2005-02-16 Thread Luben Tuikov
Hi, This patch fixes the nr_real count in sd.c, which is also used in genhd.c to print out the partitions/units. The problem is that nr_real is decremented on detach, the genhd's nr_sects is cleared but the entry is still there and is being counted for when displaying the partitions. Thus when nr