Re: [PATCH] fix suspicious rcu_dereference_check in net/sched/sch_fq_codel.c

2014-12-09 Thread David Miller
From: Valdis Kletnieks Date: Tue, 09 Dec 2014 16:15:50 -0500 > commit 46e5da40ae (net: qdisc: use rcu prefix and silence > sparse warnings) triggers a spurious warning: > > net/sched/sch_fq_codel.c:97 suspicious rcu_dereference_check() usage! > > The code should be using the _bh variant of rcu

Re: [PATCH] fix suspicious rcu_dereference_check in net/sched/sch_fq_codel.c

2014-12-09 Thread John Fastabend
On 12/09/2014 01:42 PM, Eric Dumazet wrote: > On Tue, 2014-12-09 at 16:15 -0500, Valdis Kletnieks wrote: >> commit 46e5da40ae (net: qdisc: use rcu prefix and silence >> sparse warnings) triggers a spurious warning: >> >> net/sched/sch_fq_codel.c:97 suspicious rcu_dereference_check() usage! >> >> T

Re: [PATCH] fix suspicious rcu_dereference_check in net/sched/sch_fq_codel.c

2014-12-09 Thread Eric Dumazet
On Tue, 2014-12-09 at 16:15 -0500, Valdis Kletnieks wrote: > commit 46e5da40ae (net: qdisc: use rcu prefix and silence > sparse warnings) triggers a spurious warning: > > net/sched/sch_fq_codel.c:97 suspicious rcu_dereference_check() usage! > > The code should be using the _bh variant of rcu_der

[PATCH] fix suspicious rcu_dereference_check in net/sched/sch_fq_codel.c

2014-12-09 Thread Valdis Kletnieks
commit 46e5da40ae (net: qdisc: use rcu prefix and silence sparse warnings) triggers a spurious warning: net/sched/sch_fq_codel.c:97 suspicious rcu_dereference_check() usage! The code should be using the _bh variant of rcu_dereference. Signed-off-by: Valdis Kletnieks --- net/sched/sch_fq_codel