Re: [PATCH] fix madvise vma merging

2005-08-08 Thread Prasanna Meda
Hugh Dickins wrote: > On Fri, 5 Aug 2005, Prasanna Meda wrote: > > Hugh Dickins wrote: > > > > > 2. Correct initial value of prev when starting part way into a vma: as > > >in sys_mprotect and do_mlock, it needs to be set to vma in this case > > >(vma_merge handles only that minimum of cas

Re: [PATCH] fix madvise vma merging

2005-08-06 Thread Hugh Dickins
On Fri, 5 Aug 2005, Prasanna Meda wrote: > Hugh Dickins wrote: > > > 2. Correct initial value of prev when starting part way into a vma: as > >in sys_mprotect and do_mlock, it needs to be set to vma in this case > >(vma_merge handles only that minimum of cases shown in its comments). > >

Re: [PATCH] fix madvise vma merging

2005-08-05 Thread Prasanna Meda
Hugh Dickins wrote: > Better late than never, I've at last reviewed the madvise vma merging > going into 2.6.13. Remove a pointless check and fix two little bugs - > a simple test (with /proc//maps hacked to show ReadHints) showed > both mismerges in practice: though being madvise, neither was di

[PATCH] fix madvise vma merging

2005-08-05 Thread Hugh Dickins
Better late than never, I've at last reviewed the madvise vma merging going into 2.6.13. Remove a pointless check and fix two little bugs - a simple test (with /proc//maps hacked to show ReadHints) showed both mismerges in practice: though being madvise, neither was disastrous. 1. Correct placeme