Re: [PATCH] Fix coding style issue in xfs_acl.c and xfs_aops.c

2018-11-11 Thread Dave Chinner
On Sun, Nov 11, 2018 at 08:36:03AM +0800, hmsjwzb wrote: > Possible unwrapped commit description (prefer a maximum 75 chars per line) NACK. Our preference is (and always has been) for comments to fill the entire 80 columns, just like the rest of the kernel. I have no idea who told you "75 columns

Re: [PATCH] Fix coding style issue in xfs_acl.c and xfs_aops.c

2018-11-10 Thread Joe Perches
On Sun, 2018-11-11 at 08:36 +0800, hmsjwzb wrote: > Possible unwrapped commit description (prefer a maximum 75 chars per line) This commit message makes no sense. Do say what you do to the code in the commit description. > Signed-off-by: hmsjwzb > --- > fs/xfs/xfs_acl.c | 4 +-- > fs/xfs/xf

[PATCH] Fix coding style issue in xfs_acl.c and xfs_aops.c

2018-11-10 Thread hmsjwzb
Possible unwrapped commit description (prefer a maximum 75 chars per line) Signed-off-by: hmsjwzb --- fs/xfs/xfs_acl.c | 4 +-- fs/xfs/xfs_aops.c | 73 --- 2 files changed, 39 insertions(+), 38 deletions(-) diff --git a/fs/xfs/xfs_acl.c b/fs/xfs/xfs

Re: [PATCH] fix coding style issue

2014-06-20 Thread Greg KH
On Fri, Jun 20, 2014 at 11:25:58AM -0400, rbasukala wrote: > Signed-off-by: rbasukala > --- > drivers/staging/netlogic/xlr_net.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/staging/netlogic/xlr_net.c > b/drivers/staging/netlogic/xlr_net.c > index e320d6

[PATCH] fix coding style issue

2014-06-20 Thread rbasukala
Signed-off-by: rbasukala --- drivers/staging/netlogic/xlr_net.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic/xlr_net.c index e320d6b..3ad48a0 100644 --- a/drivers/staging/netlogic/xlr_net.c +++ b/drivers/st

Re: [PATCH] Fix coding style issue in xlr_net.c

2014-03-28 Thread Dan Carpenter
The subject should be: [PATCH] Staging: netlogic: long lines in xlr_net.c You were missing the subsystem prefix: "Staging: netlogic:". regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More ma

Re: [PATCH] Fix coding style issue in xlr_net.c

2014-03-28 Thread Dan Carpenter
On Fri, Mar 28, 2014 at 10:43:43AM +0100, Neil Armstrong wrote: > checkpatch script returns the following warning: > WARNING: line over 80 characters > 310: FILE: drivers/staging/netlogic/xlr_net.c:310: > + void *accel_priv, select_queue_fallback_t fallback) > > This patch fixes the

[PATCH] Fix coding style issue in xlr_net.c

2014-03-28 Thread Neil Armstrong
checkpatch script returns the following warning: WARNING: line over 80 characters 310: FILE: drivers/staging/netlogic/xlr_net.c:310: + void *accel_priv, select_queue_fallback_t fallback) This patch fixes the coding style issue. Signed-off-by: Neil Armstrong --- drivers/staging/net