Re: [PATCH] fix a bug in ioctl(CDROMREADAUDIO) in cdrom.c in 2.2

2001-03-19 Thread Jens Axboe
On Fri, Mar 16 2001, David Mansfield wrote: > > Same thing for 2.4.2. > > > > Is my allocation loop "over engineering", or just plain bad thing to do ? > > > > I've been running this (or close: my version tries 8 frames, then jumps > immediately to 1, without trying 4 and 2 in between if the km

Re: [PATCH] fix a bug in ioctl(CDROMREADAUDIO) in cdrom.c in 2.2

2001-03-16 Thread David Mansfield
Pierre Etchemaite wrote: > > Le 14-Mar-2001, Jani Jaakkola écrivait : > > > > Using ioctl(CDROMREADAUDIO) with nframes argument being larger than 8 and > > not divisible by 8 causes kernel to read and return more audio data than > > was requested. This is bad since it clobbers up processes memory

RE: [PATCH] fix a bug in ioctl(CDROMREADAUDIO) in cdrom.c in 2.2

2001-03-15 Thread Pierre Etchemaite
Le 14-Mar-2001, Jani Jaakkola écrivait : > > Using ioctl(CDROMREADAUDIO) with nframes argument being larger than 8 and > not divisible by 8 causes kernel to read and return more audio data than > was requested. This is bad since it clobbers up processes memory > (I noticed this when my patched c