Re: [PATCH] firmware_loader: fix memory leak for paged buffer

2020-08-13 Thread Prateek Sood
On 8/13/2020 6:28 PM, Takashi Iwai wrote: On Wed, 12 Aug 2020 21:00:19 +0200, Prateek Sood wrote: vfree() is being called on paged buffer allocated using alloc_page() and mapped using vmap(). Freeing of pages in vfree() relies on nr_pages of struct vm_struct. vmap() does not update nr_pages.

Re: [PATCH] firmware_loader: fix memory leak for paged buffer

2020-08-13 Thread Takashi Iwai
On Wed, 12 Aug 2020 21:00:19 +0200, Prateek Sood wrote: > > vfree() is being called on paged buffer allocated > using alloc_page() and mapped using vmap(). > > Freeing of pages in vfree() relies on nr_pages of > struct vm_struct. vmap() does not update nr_pages. > It can lead to memory leaks. >

[PATCH] firmware_loader: fix memory leak for paged buffer

2020-08-12 Thread Prateek Sood
vfree() is being called on paged buffer allocated using alloc_page() and mapped using vmap(). Freeing of pages in vfree() relies on nr_pages of struct vm_struct. vmap() does not update nr_pages. It can lead to memory leaks. Signed-off-by: Prateek Sood --- drivers/base/firmware_loader/firmware.h