Re: [PATCH] firmware: dmi_scan: Fix ordering of product_uuid

2015-04-16 Thread Zhenzhong Duan
在 2015/4/16 17:30, Jean Delvare 写道: Le Thursday 16 April 2015 à 16:46 +0800, Zhenzhong Duan a écrit : On 2015/4/16 15:09, Jean Delvare wrote: Le Thursday 16 April 2015 à 14:22 +0800, Zhenzhong Duan a écrit : The basic idea is right, but you ignore the case dmi_walk_early may fail, though looks

Re: [PATCH] firmware: dmi_scan: Fix ordering of product_uuid

2015-04-16 Thread Jean Delvare
Le Thursday 16 April 2015 à 16:46 +0800, Zhenzhong Duan a écrit : > On 2015/4/16 15:09, Jean Delvare wrote: > > Le Thursday 16 April 2015 à 14:22 +0800, Zhenzhong Duan a écrit : > >> The basic idea is right, but you ignore the case dmi_walk_early may > >> fail, though looks impossible when bootup.

Re: [PATCH] firmware: dmi_scan: Fix ordering of product_uuid

2015-04-16 Thread Zhenzhong Duan
On 2015/4/16 15:09, Jean Delvare wrote: Hi zduan, Thanks for your reply. Le Thursday 16 April 2015 à 14:22 +0800, Zhenzhong Duan a écrit : On 2015/4/15 17:02, Jean Delvare wrote: In function dmi_present(), dmi_walk_early() calls dmi_table(), which calls dmi_decode(), which ultimately calls dm

Re: [PATCH] firmware: dmi_scan: Fix ordering of product_uuid

2015-04-16 Thread Jean Delvare
Hi zduan, Thanks for your reply. Le Thursday 16 April 2015 à 14:22 +0800, Zhenzhong Duan a écrit : > On 2015/4/15 17:02, Jean Delvare wrote: > > In function dmi_present(), dmi_walk_early() calls dmi_table(), which > > calls dmi_decode(), which ultimately calls dmi_save_uuid(). This last > > funct

Re: [PATCH] firmware: dmi_scan: Fix ordering of product_uuid

2015-04-15 Thread Zhenzhong Duan
On 2015/4/15 17:02, Jean Delvare wrote: In function dmi_present(), dmi_walk_early() calls dmi_table(), which calls dmi_decode(), which ultimately calls dmi_save_uuid(). This last function makes a decision based on the value of global variable dmi_ver. The problem is that this variable is set righ

[PATCH] firmware: dmi_scan: Fix ordering of product_uuid

2015-04-15 Thread Jean Delvare
In function dmi_present(), dmi_walk_early() calls dmi_table(), which calls dmi_decode(), which ultimately calls dmi_save_uuid(). This last function makes a decision based on the value of global variable dmi_ver. The problem is that this variable is set right _after_ dmi_walk_early() returns. So dmi