Re: [PATCH] firmware: Always initialize the fw_priv list object

2018-10-01 Thread Greg Kroah-Hartman
On Mon, Oct 01, 2018 at 11:32:16AM -0700, Bjorn Andersson wrote: > On Mon 01 Oct 11:18 PDT 2018, Luis Chamberlain wrote: > > > On Mon, Oct 01, 2018 at 03:27:03PM +0200, Niklas Cassel wrote: > > > On Thu, Sep 20, 2018 at 12:34:15AM -0700, Bjorn Andersson wrote: > > > > On Wed 19 Sep 22:22 PDT 2018,

Re: [PATCH] firmware: Always initialize the fw_priv list object

2018-10-01 Thread Luis Chamberlain
On Mon, Oct 01, 2018 at 11:32:16AM -0700, Bjorn Andersson wrote: > On Mon 01 Oct 11:18 PDT 2018, Luis Chamberlain wrote: > > > On Mon, Oct 01, 2018 at 03:27:03PM +0200, Niklas Cassel wrote: > > > On Thu, Sep 20, 2018 at 12:34:15AM -0700, Bjorn Andersson wrote: > > > > On Wed 19 Sep 22:22 PDT 2018,

Re: [PATCH] firmware: Always initialize the fw_priv list object

2018-10-01 Thread Bjorn Andersson
On Mon 01 Oct 11:18 PDT 2018, Luis Chamberlain wrote: > On Mon, Oct 01, 2018 at 03:27:03PM +0200, Niklas Cassel wrote: > > On Thu, Sep 20, 2018 at 12:34:15AM -0700, Bjorn Andersson wrote: > > > On Wed 19 Sep 22:22 PDT 2018, Greg Kroah-Hartman wrote: > > > > > > > On Wed, Sep 19, 2018 at 06:09:38P

Re: [PATCH] firmware: Always initialize the fw_priv list object

2018-10-01 Thread Luis Chamberlain
On Mon, Oct 01, 2018 at 03:27:03PM +0200, Niklas Cassel wrote: > On Thu, Sep 20, 2018 at 12:34:15AM -0700, Bjorn Andersson wrote: > > On Wed 19 Sep 22:22 PDT 2018, Greg Kroah-Hartman wrote: > > > > > On Wed, Sep 19, 2018 at 06:09:38PM -0700, Bjorn Andersson wrote: > > > > When freeing the fw_priv

Re: [PATCH] firmware: Always initialize the fw_priv list object

2018-10-01 Thread Niklas Cassel
On Thu, Sep 20, 2018 at 12:34:15AM -0700, Bjorn Andersson wrote: > On Wed 19 Sep 22:22 PDT 2018, Greg Kroah-Hartman wrote: > > > On Wed, Sep 19, 2018 at 06:09:38PM -0700, Bjorn Andersson wrote: > > > When freeing the fw_priv the item is taken off the list. This causes an > > > oops in the FW_OPT_N

Re: [PATCH] firmware: Always initialize the fw_priv list object

2018-09-20 Thread Rafael J. Wysocki
On Thu, Sep 20, 2018 at 3:07 AM Bjorn Andersson wrote: > > When freeing the fw_priv the item is taken off the list. This causes an > oops in the FW_OPT_NOCACHE case as the list object is not initialized. > > Make sure to initialize the list object regardless of this flag. > > Fixes: 422b3db2a503 (

Re: [PATCH] firmware: Always initialize the fw_priv list object

2018-09-20 Thread Bjorn Andersson
On Wed 19 Sep 22:22 PDT 2018, Greg Kroah-Hartman wrote: > On Wed, Sep 19, 2018 at 06:09:38PM -0700, Bjorn Andersson wrote: > > When freeing the fw_priv the item is taken off the list. This causes an > > oops in the FW_OPT_NOCACHE case as the list object is not initialized. > > > > Make sure to in

Re: [PATCH] firmware: Always initialize the fw_priv list object

2018-09-19 Thread Greg Kroah-Hartman
On Wed, Sep 19, 2018 at 06:09:38PM -0700, Bjorn Andersson wrote: > When freeing the fw_priv the item is taken off the list. This causes an > oops in the FW_OPT_NOCACHE case as the list object is not initialized. > > Make sure to initialize the list object regardless of this flag. > > Fixes: 422b3

[PATCH] firmware: Always initialize the fw_priv list object

2018-09-19 Thread Bjorn Andersson
When freeing the fw_priv the item is taken off the list. This causes an oops in the FW_OPT_NOCACHE case as the list object is not initialized. Make sure to initialize the list object regardless of this flag. Fixes: 422b3db2a503 ("firmware: Fix security issue with request_firmware_into_buf()") Cc