Re: [PATCH] firewire net: Ensure checksumming in upper layer.

2013-01-20 Thread David Miller
From: YOSHIFUJI Hideaki Date: Sun, 20 Jan 2013 16:43:40 +0900 > It is wrong to set skb->ip_summed to CHECKSUM_UNNECESSARY unless > the device has already checked it. > > Signed-off-by: YOSHIFUJI Hideaki Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [PATCH] firewire net: Ensure checksumming in upper layer.

2013-01-20 Thread YOSHIFUJI Hideaki
Stephan Gatzka wrote: > >> "Off-link source" means the source exists on the different L2 >> network. In other words, source is connected via router(s). >> >> ethernet firewire >> Host -- Router Host >> > > O.k., understood. But the receiving route

Re: [PATCH] firewire net: Ensure checksumming in upper layer.

2013-01-20 Thread Stephan Gatzka
"Off-link source" means the source exists on the different L2 network. In other words, source is connected via router(s). ethernet firewire Host -- Router Host O.k., understood. But the receiving router verifies the checksum of incoming pack

Re: [PATCH] firewire net: Ensure checksumming in upper layer.

2013-01-20 Thread YOSHIFUJI Hideaki
Stephan Gatzka wrote: > >>> Indeed neither the device nor the lower drivers check protocol checksums. >>> But the CRCs of the encapsulating 1394 packets are checked in hardware. >>> Shall protocol checksums be verified regardless? >> >> Yes, because packets may come from off-link source. >> > > H

Re: [PATCH] firewire net: Ensure checksumming in upper layer.

2013-01-20 Thread Stephan Gatzka
Indeed neither the device nor the lower drivers check protocol checksums. But the CRCs of the encapsulating 1394 packets are checked in hardware. Shall protocol checksums be verified regardless? Yes, because packets may come from off-link source. Hm, I can't see any off-link packets coming

Re: [PATCH] firewire net: Ensure checksumming in upper layer.

2013-01-20 Thread YOSHIFUJI Hideaki
Stefan Richter wrote: > On Jan 20 YOSHIFUJI Hideaki wrote: >> It is wrong to set skb->ip_summed to CHECKSUM_UNNECESSARY unless >> the device has already checked it. >> >> Signed-off-by: YOSHIFUJI Hideaki >> --- >> drivers/firewire/net.c |2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] firewire net: Ensure checksumming in upper layer.

2013-01-20 Thread Stefan Richter
On Jan 20 YOSHIFUJI Hideaki wrote: > It is wrong to set skb->ip_summed to CHECKSUM_UNNECESSARY unless > the device has already checked it. > > Signed-off-by: YOSHIFUJI Hideaki > --- > drivers/firewire/net.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/fire

[PATCH] firewire net: Ensure checksumming in upper layer.

2013-01-19 Thread YOSHIFUJI Hideaki
It is wrong to set skb->ip_summed to CHECKSUM_UNNECESSARY unless the device has already checked it. Signed-off-by: YOSHIFUJI Hideaki --- drivers/firewire/net.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c index e7a711f5..d