Re: [PATCH] fbdev: offb: Fix OF node name handling

2019-01-11 Thread Bartlomiej Zolnierkiewicz
On 01/07/2019 09:11 PM, Mathieu Malaterre wrote: > On Mon, Jan 7, 2019 at 6:31 PM Rob Herring wrote: >> >> Commit 5c63e407aaab ("fbdev: Convert to using %pOFn instead of >> device_node.name") changed how the OF FB driver handles the OF node >> name. This missed the case where the node name is pa

Re: [PATCH] fbdev: offb: Fix OF node name handling

2019-01-07 Thread Rob Herring
On Mon, Jan 7, 2019 at 2:36 PM Mathieu Malaterre wrote: > > Hi Rob, > > On Mon, Jan 7, 2019 at 9:11 PM Mathieu Malaterre wrote: > > > > On Mon, Jan 7, 2019 at 6:31 PM Rob Herring wrote: > > > > > > Commit 5c63e407aaab ("fbdev: Convert to using %pOFn instead of > > > device_node.name") changed ho

Re: [PATCH] fbdev: offb: Fix OF node name handling

2019-01-07 Thread Mathieu Malaterre
Hi Rob, On Mon, Jan 7, 2019 at 9:11 PM Mathieu Malaterre wrote: > > On Mon, Jan 7, 2019 at 6:31 PM Rob Herring wrote: > > > > Commit 5c63e407aaab ("fbdev: Convert to using %pOFn instead of > > device_node.name") changed how the OF FB driver handles the OF node > > name. This missed the case wher

Re: [PATCH] fbdev: offb: Fix OF node name handling

2019-01-07 Thread Mathieu Malaterre
On Mon, Jan 7, 2019 at 6:31 PM Rob Herring wrote: > > Commit 5c63e407aaab ("fbdev: Convert to using %pOFn instead of > device_node.name") changed how the OF FB driver handles the OF node > name. This missed the case where the node name is passed to > offb_init_palette_hacks(). This results in a NU

[PATCH] fbdev: offb: Fix OF node name handling

2019-01-07 Thread Rob Herring
Commit 5c63e407aaab ("fbdev: Convert to using %pOFn instead of device_node.name") changed how the OF FB driver handles the OF node name. This missed the case where the node name is passed to offb_init_palette_hacks(). This results in a NULL ptr dereference in strncmp and breaks any system except on