Re: [f2fs-dev] [PATCH] f2fs: merge WRITE bio into previous WRITE_SYNC

2016-09-08 Thread Chao Yu
On 2016/9/8 8:26, Jaegeuk Kim wrote: > On Wed, Sep 07, 2016 at 10:12:17PM +0800, Chao Yu wrote: >> On 2016/9/3 2:36, Jaegeuk Kim wrote: >>> On Fri, Sep 02, 2016 at 03:33:33PM +0800, Chao Yu wrote: Hi Jaegeuk, On 2016/8/27 8:53, Jaegeuk Kim wrote: > This can avoid bio splits due t

Re: [f2fs-dev] [PATCH] f2fs: merge WRITE bio into previous WRITE_SYNC

2016-09-07 Thread Jaegeuk Kim
On Wed, Sep 07, 2016 at 10:12:17PM +0800, Chao Yu wrote: > On 2016/9/3 2:36, Jaegeuk Kim wrote: > > On Fri, Sep 02, 2016 at 03:33:33PM +0800, Chao Yu wrote: > >> Hi Jaegeuk, > >> > >> On 2016/8/27 8:53, Jaegeuk Kim wrote: > >>> This can avoid bio splits due to different op_flags. > >> > >> I though

Re: [f2fs-dev] [PATCH] f2fs: merge WRITE bio into previous WRITE_SYNC

2016-09-07 Thread Chao Yu
On 2016/9/3 2:36, Jaegeuk Kim wrote: > On Fri, Sep 02, 2016 at 03:33:33PM +0800, Chao Yu wrote: >> Hi Jaegeuk, >> >> On 2016/8/27 8:53, Jaegeuk Kim wrote: >>> This can avoid bio splits due to different op_flags. >> >> I thought about this, but I think this is not a good idea to increase merging >>

Re: [PATCH] f2fs: merge WRITE bio into previous WRITE_SYNC

2016-09-02 Thread Jaegeuk Kim
On Fri, Sep 02, 2016 at 03:33:33PM +0800, Chao Yu wrote: > Hi Jaegeuk, > > On 2016/8/27 8:53, Jaegeuk Kim wrote: > > This can avoid bio splits due to different op_flags. > > I thought about this, but I think this is not a good idea to increase merging > ratio of pages in bio. It breaks the rule o

Re: [PATCH] f2fs: merge WRITE bio into previous WRITE_SYNC

2016-09-02 Thread Chao Yu
Hi Jaegeuk, On 2016/8/27 8:53, Jaegeuk Kim wrote: > This can avoid bio splits due to different op_flags. I thought about this, but I think this is not a good idea to increase merging ratio of pages in bio. It breaks the rule of SYNC/ASYNC IO defined by system which indicate degree of IO emergency

[PATCH] f2fs: merge WRITE bio into previous WRITE_SYNC

2016-08-26 Thread Jaegeuk Kim
This can avoid bio splits due to different op_flags. Signed-off-by: Jaegeuk Kim --- fs/f2fs/data.c | 5 + 1 file changed, 5 insertions(+) diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c index 7c8e219..c7c2022 100644 --- a/fs/f2fs/data.c +++ b/fs/f2fs/data.c @@ -267,6 +267,11 @@ void f2fs_submi