Re: [PATCH] f2fs: Remove BUG_ON in dec_valid_node_count

2013-05-15 Thread Chris Fries
Hi, Abandon my patch in favor of Jaegeuk's recovery accounting fix (mine has a copy paste error anyway) [f2fs-dev] [PATCH 1/2] f2fs: fix inconsistency of block count during recovery This patch solves the issue completely. -Chris On Tue, May 14, 2013 at 2:26 PM, Russell Knize wrote: > > The n

Re: [PATCH] f2fs: Remove BUG_ON in dec_valid_node_count

2013-05-14 Thread Russell Knize
The node accounting errors seem to be creeping in during recovery. Once the error is introduced in the total counts, it gets recorded in the next checkpoint and is carried forward. Often times the error crops-up after a failed recovery attempt, such as when recovery attempts to recover an inode be

Re: [PATCH] f2fs: Remove BUG_ON in dec_valid_node_count

2013-05-13 Thread Haicheng Li
On Sun, May 12, 2013 at 10:46:27PM -0500, Chris Fries wrote: > From: Chris Fries > > Panic loops while running LTP fsstress has been able to get > a disk into two different panic loops from dec_valid_node_count. > f2fs.h:714 BUG_ON(sbi->total_valid_node_count < count); This is interesting catc

[PATCH] f2fs: Remove BUG_ON in dec_valid_node_count

2013-05-12 Thread Chris Fries
From: Chris Fries Panic loops while running LTP fsstress has been able to get a disk into two different panic loops from dec_valid_node_count. f2fs.h:714 BUG_ON(sbi->total_valid_node_count < count); Once, it happens during recovery itself, and the disk would cause a panic every time it mounted.