Re: [PATCH] f2fs: Fix recover when nid of non-inode dnode < nid of inode

2014-09-17 Thread Jaegeuk Kim
On Mon, Sep 15, 2014 at 01:14:09PM +0800, Huang Ying wrote: > On Sun, 2014-09-14 at 00:48 -0700, Jaegeuk Kim wrote: > > On Sat, Sep 13, 2014 at 10:23:18PM +0800, Huang Ying wrote: > > > On Fri, 2014-09-12 at 15:34 +0800, Huang Ying wrote: > > > > On Thu, 2014-09-11 at 22:13 -0700, Jaegeuk Kim wrote

Re: [PATCH] f2fs: Fix recover when nid of non-inode dnode < nid of inode

2014-09-15 Thread Huang Ying
On Sun, 2014-09-14 at 00:48 -0700, Jaegeuk Kim wrote: > On Sat, Sep 13, 2014 at 10:23:18PM +0800, Huang Ying wrote: > > On Fri, 2014-09-12 at 15:34 +0800, Huang Ying wrote: > > > On Thu, 2014-09-11 at 22:13 -0700, Jaegeuk Kim wrote: > > > > On Thu, Sep 11, 2014 at 08:25:17PM +0800, Huang Ying wrote

Re: [PATCH] f2fs: Fix recover when nid of non-inode dnode < nid of inode

2014-09-14 Thread Huang Ying
On Sun, 2014-09-14 at 00:38 -0700, Jaegeuk Kim wrote: > On Fri, Sep 12, 2014 at 03:34:48PM +0800, Huang Ying wrote: > > On Thu, 2014-09-11 at 22:13 -0700, Jaegeuk Kim wrote: > > > On Thu, Sep 11, 2014 at 08:25:17PM +0800, Huang Ying wrote: > > > > > > > > On Wed, 2014-09-10 at 22:37 -0700, Jaegeuk

Re: [PATCH] f2fs: Fix recover when nid of non-inode dnode < nid of inode

2014-09-14 Thread Jaegeuk Kim
On Sat, Sep 13, 2014 at 10:23:18PM +0800, Huang Ying wrote: > On Fri, 2014-09-12 at 15:34 +0800, Huang Ying wrote: > > On Thu, 2014-09-11 at 22:13 -0700, Jaegeuk Kim wrote: > > > On Thu, Sep 11, 2014 at 08:25:17PM +0800, Huang Ying wrote: > > > > > > > > On Wed, 2014-09-10 at 22:37 -0700, Jaegeuk

Re: [PATCH] f2fs: Fix recover when nid of non-inode dnode < nid of inode

2014-09-14 Thread Jaegeuk Kim
On Fri, Sep 12, 2014 at 03:34:48PM +0800, Huang Ying wrote: > On Thu, 2014-09-11 at 22:13 -0700, Jaegeuk Kim wrote: > > On Thu, Sep 11, 2014 at 08:25:17PM +0800, Huang Ying wrote: > > > > > > On Wed, 2014-09-10 at 22:37 -0700, Jaegeuk Kim wrote: > > > > On Wed, Sep 10, 2014 at 07:08:32PM +0800, hu

Re: [PATCH] f2fs: Fix recover when nid of non-inode dnode < nid of inode

2014-09-13 Thread Huang Ying
On Fri, 2014-09-12 at 15:34 +0800, Huang Ying wrote: > On Thu, 2014-09-11 at 22:13 -0700, Jaegeuk Kim wrote: > > On Thu, Sep 11, 2014 at 08:25:17PM +0800, Huang Ying wrote: > > > > > > On Wed, 2014-09-10 at 22:37 -0700, Jaegeuk Kim wrote: > > > > On Wed, Sep 10, 2014 at 07:08:32PM +0800, huang yin

Re: [PATCH] f2fs: Fix recover when nid of non-inode dnode < nid of inode

2014-09-12 Thread Huang Ying
On Thu, 2014-09-11 at 22:13 -0700, Jaegeuk Kim wrote: > On Thu, Sep 11, 2014 at 08:25:17PM +0800, Huang Ying wrote: > > > > On Wed, 2014-09-10 at 22:37 -0700, Jaegeuk Kim wrote: > > > On Wed, Sep 10, 2014 at 07:08:32PM +0800, huang ying wrote: > > > > On Wed, Sep 10, 2014 at 3:21 PM, Jaegeuk Kim

Re: [PATCH] f2fs: Fix recover when nid of non-inode dnode < nid of inode

2014-09-11 Thread Jaegeuk Kim
On Thu, Sep 11, 2014 at 08:25:17PM +0800, Huang Ying wrote: > > On Wed, 2014-09-10 at 22:37 -0700, Jaegeuk Kim wrote: > > On Wed, Sep 10, 2014 at 07:08:32PM +0800, huang ying wrote: > > > On Wed, Sep 10, 2014 at 3:21 PM, Jaegeuk Kim wrote: > > > > > > > On Tue, Sep 09, 2014 at 07:31:49PM +0800,

Re: [f2fs-dev] [PATCH] f2fs: Fix recover when nid of non-inode dnode < nid of inode

2014-09-11 Thread Huang Ying
> Subject: Re: [f2fs-dev] [PATCH] f2fs: Fix recover when nid of non-inode > > dnode < nid of inode > > > > On Wed, Sep 10, 2014 at 07:08:32PM +0800, huang ying wrote: > > > On Wed, Sep 10, 2014 at 3:21 PM, Jaegeuk Kim wrote: > > > > > > > On Tu

Re: [PATCH] f2fs: Fix recover when nid of non-inode dnode < nid of inode

2014-09-11 Thread Huang Ying
On Wed, 2014-09-10 at 22:37 -0700, Jaegeuk Kim wrote: > On Wed, Sep 10, 2014 at 07:08:32PM +0800, huang ying wrote: > > On Wed, Sep 10, 2014 at 3:21 PM, Jaegeuk Kim wrote: > > > > > On Tue, Sep 09, 2014 at 07:31:49PM +0800, huang ying wrote: > > > > On Tue, Sep 9, 2014 at 3:09 PM, Jaegeuk Kim w

RE: [f2fs-dev] [PATCH] f2fs: Fix recover when nid of non-inode dnode < nid of inode

2014-09-11 Thread Chao Yu
> -Original Message- > From: Jaegeuk Kim [mailto:jaeg...@kernel.org] > Sent: Thursday, September 11, 2014 1:37 PM > To: huang ying > Cc: linux-f2fs-de...@lists.sourceforge.net; LKML; Huang Ying > Subject: Re: [f2fs-dev] [PATCH] f2fs: Fix recover when nid of non-inode

Re: [PATCH] f2fs: Fix recover when nid of non-inode dnode < nid of inode

2014-09-10 Thread Jaegeuk Kim
On Wed, Sep 10, 2014 at 07:08:32PM +0800, huang ying wrote: > On Wed, Sep 10, 2014 at 3:21 PM, Jaegeuk Kim wrote: > > > On Tue, Sep 09, 2014 at 07:31:49PM +0800, huang ying wrote: > > > On Tue, Sep 9, 2014 at 3:09 PM, Jaegeuk Kim wrote: > > > > > > > Hi, > > > > > > > > On Tue, Sep 09, 2014 at 0

Re: [PATCH] f2fs: Fix recover when nid of non-inode dnode < nid of inode

2014-09-10 Thread Jaegeuk Kim
On Tue, Sep 09, 2014 at 07:31:49PM +0800, huang ying wrote: > On Tue, Sep 9, 2014 at 3:09 PM, Jaegeuk Kim wrote: > > > Hi, > > > > On Tue, Sep 09, 2014 at 01:39:30PM +0800, Huang Ying wrote: > > > On Mon, 2014-09-08 at 22:23 -0700, Jaegeuk Kim wrote: > > > > Hi Huang, > > > > > > > > On Mon, Sep

Re: [PATCH] f2fs: Fix recover when nid of non-inode dnode < nid of inode

2014-09-09 Thread Jaegeuk Kim
Hi, On Tue, Sep 09, 2014 at 01:39:30PM +0800, Huang Ying wrote: > On Mon, 2014-09-08 at 22:23 -0700, Jaegeuk Kim wrote: > > Hi Huang, > > > > On Mon, Sep 08, 2014 at 07:38:26PM +0800, Huang Ying wrote: > > > For fsync, if the nid of a non-inode dnode < nid of inode and the > > > inode is not chec

Re: [PATCH] f2fs: Fix recover when nid of non-inode dnode < nid of inode

2014-09-08 Thread Huang Ying
On Mon, 2014-09-08 at 22:23 -0700, Jaegeuk Kim wrote: > Hi Huang, > > On Mon, Sep 08, 2014 at 07:38:26PM +0800, Huang Ying wrote: > > For fsync, if the nid of a non-inode dnode < nid of inode and the > > inode is not checkpointed. The non-inode dnode may be written before > > inode. So in find_f

Re: [PATCH] f2fs: Fix recover when nid of non-inode dnode < nid of inode

2014-09-08 Thread Jaegeuk Kim
Hi Huang, On Mon, Sep 08, 2014 at 07:38:26PM +0800, Huang Ying wrote: > For fsync, if the nid of a non-inode dnode < nid of inode and the > inode is not checkpointed. The non-inode dnode may be written before > inode. So in find_fsync_dnodes, f2fs_iget will fail, cause the > recovery fail. > >

[PATCH] f2fs: Fix recover when nid of non-inode dnode < nid of inode

2014-09-08 Thread Huang Ying
For fsync, if the nid of a non-inode dnode < nid of inode and the inode is not checkpointed. The non-inode dnode may be written before inode. So in find_fsync_dnodes, f2fs_iget will fail, cause the recovery fail. Usually, inode will be allocated before non-inode dnode, so the nid of inode < nid