Re: [PATCH] ext4 crypto: migrate into vfs's crypto engine

2016-05-07 Thread Jaegeuk Kim
Hi Eric, Thank you for the review. On Fri, May 06, 2016 at 09:31:02PM -0500, Eric Biggers wrote: > Hi Jaegeuk, > > On Mon, Apr 25, 2016 at 05:15:36PM -0700, Jaegeuk Kim wrote: > > This patch removes the most parts of internal crypto codes. > > And then, it modifies and adds some ext4-specific cr

Re: [PATCH] ext4 crypto: migrate into vfs's crypto engine

2016-05-06 Thread Eric Biggers
Hi Jaegeuk, On Mon, Apr 25, 2016 at 05:15:36PM -0700, Jaegeuk Kim wrote: > This patch removes the most parts of internal crypto codes. > And then, it modifies and adds some ext4-specific crypt codes to use the > generic > facility. Except for the key name prefix issue that Ted pointed out, this

Re: [PATCH] ext4 crypto: migrate into vfs's crypto engine

2016-05-05 Thread Jaegeuk Kim
On Thu, May 05, 2016 at 08:44:12AM -0400, Theodore Ts'o wrote: > On Wed, May 04, 2016 at 09:22:48PM -0700, Jaegeuk Kim wrote: > > > > Got it. Let me add (*key_prefix(inode)) in fscrypt_operations so that > > filesystem > > can give a specific prefix additionally. > > Once fscrypto supports both o

Re: [PATCH] ext4 crypto: migrate into vfs's crypto engine

2016-05-05 Thread Theodore Ts'o
On Wed, May 04, 2016 at 09:22:48PM -0700, Jaegeuk Kim wrote: > > Got it. Let me add (*key_prefix(inode)) in fscrypt_operations so that > filesystem > can give a specific prefix additionally. > Once fscrypto supports both of prefixes, does e4crypto have to set "fscrypto"? > The "ext4" should work

Re: [PATCH] ext4 crypto: migrate into vfs's crypto engine

2016-05-04 Thread Jaegeuk Kim
On Wed, May 04, 2016 at 11:20:22PM -0400, Theodore Ts'o wrote: > On Mon, Apr 25, 2016 at 05:15:36PM -0700, Jaegeuk Kim wrote: > > This patch removes the most parts of internal crypto codes. > > And then, it modifies and adds some ext4-specific crypt codes to use the > > generic > > facility. > >

Re: [PATCH] ext4 crypto: migrate into vfs's crypto engine

2016-05-04 Thread Theodore Ts'o
On Mon, Apr 25, 2016 at 05:15:36PM -0700, Jaegeuk Kim wrote: > This patch removes the most parts of internal crypto codes. > And then, it modifies and adds some ext4-specific crypt codes to use the > generic > facility. > > Signed-off-by: Jaegeuk Kim So I just tried this patch, and one big prob

[PATCH] ext4 crypto: migrate into vfs's crypto engine

2016-04-25 Thread Jaegeuk Kim
This patch removes the most parts of internal crypto codes. And then, it modifies and adds some ext4-specific crypt codes to use the generic facility. Signed-off-by: Jaegeuk Kim --- fs/ext4/Kconfig | 12 +- fs/ext4/Makefile| 2 - fs/ext4/crypto.c| 536 -