RE: [PATCH] ext4: remove the null check of bio_vec page

2020-12-03 Thread Tianxianting
Thanks Ted :) -Original Message- From: Theodore Y. Ts'o [mailto:ty...@mit.edu] Sent: Thursday, December 03, 2020 10:11 PM To: Jan Kara Cc: tianxianting (RD) ; adilger.ker...@dilger.ca; linux-e...@vger.kernel.org; linux-kernel@vger.kernel.org Subject: Re: [PATCH] ext4: remove the

Re: [PATCH] ext4: remove the null check of bio_vec page

2020-12-03 Thread Theodore Y. Ts'o
On Wed, Oct 21, 2020 at 12:25:03PM +0200, Jan Kara wrote: > On Tue 20-10-20 16:22:01, Xianting Tian wrote: > > bv_page can't be NULL in a valid bio_vec, so we can remove the NULL check, > > as we did in other places when calling bio_for_each_segment_all() to go > > through all bio_vec of a bio. > >

RE: [PATCH] ext4: remove the null check of bio_vec page

2020-12-03 Thread Tianxianting
-kernel@vger.kernel.org Subject: Re: [PATCH] ext4: remove the null check of bio_vec page On Fri 23-10-20 16:38:16, Tianxianting wrote: > Thanks Jan > Can be the patch applied? Ted Tso is the ext4 maintainer so he should eventually pick up and apply the patch. But since there's merge windo

Re: [PATCH] ext4: remove the null check of bio_vec page

2020-10-23 Thread Jan Kara
.edu; adilger.ker...@dilger.ca; j...@suse.cz; > linux-e...@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] ext4: remove the null check of bio_vec page > > On Tue 20-10-20 16:22:01, Xianting Tian wrote: > > bv_page can't be NULL in a valid bio_vec, s

RE: [PATCH] ext4: remove the null check of bio_vec page

2020-10-23 Thread Tianxianting
: [PATCH] ext4: remove the null check of bio_vec page On Tue 20-10-20 16:22:01, Xianting Tian wrote: > bv_page can't be NULL in a valid bio_vec, so we can remove the NULL > check, as we did in other places when calling > bio_for_each_segment_all() to go through all bio_vec of a bio. &

Re: [PATCH] ext4: remove the null check of bio_vec page

2020-10-21 Thread Jan Kara
On Tue 20-10-20 16:22:01, Xianting Tian wrote: > bv_page can't be NULL in a valid bio_vec, so we can remove the NULL check, > as we did in other places when calling bio_for_each_segment_all() to go > through all bio_vec of a bio. > > Signed-off-by: Xianting Tian Thanks for the patch. It looks go

[PATCH] ext4: remove the null check of bio_vec page

2020-10-20 Thread Xianting Tian
bv_page can't be NULL in a valid bio_vec, so we can remove the NULL check, as we did in other places when calling bio_for_each_segment_all() to go through all bio_vec of a bio. Signed-off-by: Xianting Tian --- fs/ext4/page-io.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/ext4/page-i