Re: [PATCH] ext4: explain encoding of 34-bit a,c,mtime values

2014-02-10 Thread Andreas Dilger
On Feb 10, 2014, at 10:12 PM, David Turner wrote: > On Tue, 2014-01-21 at 22:22 -0800, Darrick J. Wong wrote: >> On Mon, Nov 11, 2013 at 07:30:18PM -0500, Theodore Ts'o wrote: >>> On Sun, Nov 10, 2013 at 02:56:54AM -0500, David Turner wrote: b. Use Andreas's encoding, which is incompatible wi

Re: [PATCH] ext4: explain encoding of 34-bit a,c,mtime values

2014-02-10 Thread David Turner
On Tue, 2014-01-21 at 22:22 -0800, Darrick J. Wong wrote: > On Mon, Nov 11, 2013 at 07:30:18PM -0500, Theodore Ts'o wrote: > > On Sun, Nov 10, 2013 at 02:56:54AM -0500, David Turner wrote: > > > b. Use Andreas's encoding, which is incompatible with pre-1970 files > > > written on 64-bit systems. >

Re: [PATCH] ext4: explain encoding of 34-bit a,c,mtime values

2014-01-21 Thread Darrick J. Wong
On Mon, Nov 11, 2013 at 07:30:18PM -0500, Theodore Ts'o wrote: > On Sun, Nov 10, 2013 at 02:56:54AM -0500, David Turner wrote: > > b. Use Andreas's encoding, which is incompatible with pre-1970 files > > written on 64-bit systems. > > > > I don't care about currently-existing post-2038 files, becau

Re: [PATCH] ext4: explain encoding of 34-bit a,c,mtime values

2013-11-12 Thread David Turner
On Tue, 2013-11-12 at 15:03 -0800, Darrick J. Wong wrote: > On Mon, Nov 11, 2013 at 07:30:18PM -0500, Theodore Ts'o wrote: > > On Sun, Nov 10, 2013 at 02:56:54AM -0500, David Turner wrote: > > > b. Use Andreas's encoding, which is incompatible with pre-1970 files > > > written on 64-bit systems. >

Re: [PATCH] ext4: explain encoding of 34-bit a,c,mtime values

2013-11-12 Thread Darrick J. Wong
On Mon, Nov 11, 2013 at 07:30:18PM -0500, Theodore Ts'o wrote: > On Sun, Nov 10, 2013 at 02:56:54AM -0500, David Turner wrote: > > b. Use Andreas's encoding, which is incompatible with pre-1970 files > > written on 64-bit systems. > > > > I don't care about currently-existing post-2038 files, becau

Re: [PATCH] ext4: explain encoding of 34-bit a,c,mtime values

2013-11-12 Thread Andreas Dilger
On Nov 11, 2013, at 5:30 PM, Theodore Ts'o wrote: > On Sun, Nov 10, 2013 at 02:56:54AM -0500, David Turner wrote: >> b. Use Andreas's encoding, which is incompatible with pre-1970 files >> written on 64-bit systems. >> >> I don't care about currently-existing post-2038 files, because I believe >>

Re: [PATCH] ext4: explain encoding of 34-bit a,c,mtime values

2013-11-12 Thread Theodore Ts'o
On Sun, Nov 10, 2013 at 02:56:54AM -0500, David Turner wrote: > b. Use Andreas's encoding, which is incompatible with pre-1970 files > written on 64-bit systems. > > I don't care about currently-existing post-2038 files, because I believe > that nobody has a valid reason to have such files. Howeve

Re: [PATCH] ext4: explain encoding of 34-bit a,c,mtime values

2013-11-09 Thread David Turner
On Sat, 2013-11-09 at 15:51 -0800, Mark Harris wrote: > > The problem with the existing encoding is that pre-1970 dates are > encoded with extra bits 1,1 in 64-bit kernels with ext4, but on 32-bit > kernels and inodes that were originally written as ext3 the extra bits > will be 0,0. Currently, b

Re: [PATCH] ext4: explain encoding of 34-bit a,c,mtime values

2013-11-09 Thread Mark Harris
On 8 November 2013 23:19, David Turner wrote: > > On Fri, 2013-11-08 at 14:37 -0700, Andreas Dilger wrote: > > On Nov 7, 2013, at 4:26 PM, David Turner wrote: > > > On Fri, 2013-11-08 at 00:14 +0100, Jan Kara wrote: > > >> Still unnecessary type cast here (but that's a cosmetic issue). > > > ...

[PATCH] ext4: explain encoding of 34-bit a,c,mtime values

2013-11-08 Thread David Turner
On Fri, 2013-11-08 at 14:37 -0700, Andreas Dilger wrote: > On Nov 7, 2013, at 4:26 PM, David Turner wrote: > > On Fri, 2013-11-08 at 00:14 +0100, Jan Kara wrote: > >> Still unnecessary type cast here (but that's a cosmetic issue). > > ... > >> Otherwise the patch looks good. You can add: > >> Revi