Re: [PATCH] ext4: add error handling when discard cmd is fail in FITRIM

2012-07-31 Thread Ashish Sangwan
>> How about instead of propagating the error to user and breaking out of >> the discard, just print a warning message like: >> ext4_warning(sb, "error %d while trimming group block from %d to >> %d\n",ret, start, next); > > That's what I said. I think that those errors should be logged, but > I am

Re: [PATCH] ext4: add error handling when discard cmd is fail in FITRIM

2012-07-30 Thread Ashish Sangwan
gt; Cc: linux-kernel@vger.kernel.org, Namjae Jeon , >> Amit Sahrawat >> Subject: [PATCH] ext4: add error handling when discard cmd is fail in FITRIM >> >> Although free extents is proper not trimmed(mmc driver return error code >> while sending trim command), current

Re: [PATCH] ext4: add error handling when discard cmd is fail in FITRIM

2012-07-30 Thread Lukáš Czerner
ct: [PATCH] ext4: add error handling when discard cmd is fail in FITRIM > > Although free extents is proper not trimmed(mmc driver return error code > while sending trim command), currently FITRIM ioctl return success. > Add exception routine to inform user error code. > > #> .

[PATCH] ext4: add error handling when discard cmd is fail in FITRIM

2012-07-29 Thread Namjae Jeon
Although free extents is proper not trimmed(mmc driver return error code while sending trim command), currently FITRIM ioctl return success. Add exception routine to inform user error code. #> ./fitrim_test end_request: I/O error, dev mmcblk0, sector 27232 EXT4-fs warning (device mmcblk0): ext4_tr