Re: [PATCH] ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it

2020-10-23 Thread David Gow
On Fri, Oct 23, 2020 at 10:07 PM Theodore Y. Ts'o wrote: > > On Thu, Oct 22, 2020 at 04:52:52PM -0700, Brendan Higgins wrote: > > So you, me, Luis, David, and a whole bunch of other people have been > > thinking about this problem for a while. What if we just put > > kunitconfig fragments in direc

Re: [PATCH] ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it

2020-10-23 Thread Theodore Y. Ts'o
On Thu, Oct 22, 2020 at 04:52:52PM -0700, Brendan Higgins wrote: > So you, me, Luis, David, and a whole bunch of other people have been > thinking about this problem for a while. What if we just put > kunitconfig fragments in directories along side the test files they > enable? > > For example, we

Re: [PATCH] ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it

2020-10-22 Thread Brendan Higgins
On Wed, Oct 21, 2020 at 3:36 PM Theodore Y. Ts'o wrote: > > On Wed, Oct 21, 2020 at 02:16:56PM -0700, Randy Dunlap wrote: > > On 10/21/20 2:15 PM, Brendan Higgins wrote: > > > On Tue, Oct 20, 2020 at 12:37 AM Geert Uytterhoeven > > > wrote: > > >> > > >> EXT4_KUNIT_TESTS selects EXT4_FS, thus ena

Re: [PATCH] ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it

2020-10-22 Thread Geert Uytterhoeven
Hi Ted, On Thu, Oct 22, 2020 at 5:43 AM Theodore Y. Ts'o wrote: > On Wed, Oct 21, 2020 at 04:07:15PM -0700, Randy Dunlap wrote: > > > I'm don't particularly care how this gets achieved, but please think > > > about how to make it easy for a kernel developer to run a specific set > > > of subsyste

Re: [PATCH] ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it

2020-10-21 Thread Randy Dunlap
On 10/21/20 8:43 PM, Theodore Y. Ts'o wrote: > On Wed, Oct 21, 2020 at 04:07:15PM -0700, Randy Dunlap wrote: >>> I'm don't particularly care how this gets achieved, but please think >>> about how to make it easy for a kernel developer to run a specific set >>> of subsystem unit tests. (In fact, be

Re: [PATCH] ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it

2020-10-21 Thread Theodore Y. Ts'o
On Wed, Oct 21, 2020 at 04:07:15PM -0700, Randy Dunlap wrote: > > I'm don't particularly care how this gets achieved, but please think > > about how to make it easy for a kernel developer to run a specific set > > of subsystem unit tests. (In fact, being able to do something like > > "kunit.py run

Re: [PATCH] ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it

2020-10-21 Thread Randy Dunlap
On 10/21/20 3:36 PM, Theodore Y. Ts'o wrote: > On Wed, Oct 21, 2020 at 02:16:56PM -0700, Randy Dunlap wrote: >> On 10/21/20 2:15 PM, Brendan Higgins wrote: >>> On Tue, Oct 20, 2020 at 12:37 AM Geert Uytterhoeven >>> wrote: EXT4_KUNIT_TESTS selects EXT4_FS, thus enabling an optional featu

Re: [PATCH] ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it

2020-10-21 Thread Theodore Y. Ts'o
On Wed, Oct 21, 2020 at 02:16:56PM -0700, Randy Dunlap wrote: > On 10/21/20 2:15 PM, Brendan Higgins wrote: > > On Tue, Oct 20, 2020 at 12:37 AM Geert Uytterhoeven > > wrote: > >> > >> EXT4_KUNIT_TESTS selects EXT4_FS, thus enabling an optional feature the > >> user may not want to enable. Fix th

Re: [PATCH] ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it

2020-10-21 Thread Randy Dunlap
On 10/21/20 2:29 PM, David Gow wrote: > On Thu, Oct 22, 2020 at 5:15 AM Brendan Higgins > wrote: >> >> On Tue, Oct 20, 2020 at 12:37 AM Geert Uytterhoeven >> wrote: >>> >>> EXT4_KUNIT_TESTS selects EXT4_FS, thus enabling an optional feature the >>> user may not want to enable. Fix this by making

Re: [PATCH] ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it

2020-10-21 Thread David Gow
On Thu, Oct 22, 2020 at 5:15 AM Brendan Higgins wrote: > > On Tue, Oct 20, 2020 at 12:37 AM Geert Uytterhoeven > wrote: > > > > EXT4_KUNIT_TESTS selects EXT4_FS, thus enabling an optional feature the > > user may not want to enable. Fix this by making the test depend on > > EXT4_FS instead. > >

Re: [PATCH] ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it

2020-10-21 Thread Randy Dunlap
On 10/21/20 2:15 PM, Brendan Higgins wrote: > On Tue, Oct 20, 2020 at 12:37 AM Geert Uytterhoeven > wrote: >> >> EXT4_KUNIT_TESTS selects EXT4_FS, thus enabling an optional feature the >> user may not want to enable. Fix this by making the test depend on >> EXT4_FS instead. >> >> Fixes: 1cbeab1b2

Re: [PATCH] ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it

2020-10-21 Thread Brendan Higgins
On Tue, Oct 20, 2020 at 12:37 AM Geert Uytterhoeven wrote: > > EXT4_KUNIT_TESTS selects EXT4_FS, thus enabling an optional feature the > user may not want to enable. Fix this by making the test depend on > EXT4_FS instead. > > Fixes: 1cbeab1b242d16fd ("ext4: add kunit test for decoding extended

[PATCH] ext: EXT4_KUNIT_TESTS should depend on EXT4_FS instead of selecting it

2020-10-20 Thread Geert Uytterhoeven
EXT4_KUNIT_TESTS selects EXT4_FS, thus enabling an optional feature the user may not want to enable. Fix this by making the test depend on EXT4_FS instead. Fixes: 1cbeab1b242d16fd ("ext4: add kunit test for decoding extended timestamps") Signed-off-by: Geert Uytterhoeven --- See also "[PATCH] m