RE: [PATCH] exfat: remove EXFAT_SB_DIRTY flag

2020-06-15 Thread kohada.tetsuh...@dc.mitsubishielectric.co.jp
> > On 2020/06/12 17:34, Sungjong Seo wrote: > > >> remove EXFAT_SB_DIRTY flag and related codes. > > >> > > >> This flag is set/reset in exfat_put_super()/exfat_sync_fs() to > > >> avoid sync_blockdev(). > > >> However ... > > >> - exfat_put_super(): > > >> Before calling this, the VFS has already

RE: [PATCH] exfat: remove EXFAT_SB_DIRTY flag

2020-06-14 Thread Sungjong Seo
> On 2020/06/12 17:34, Sungjong Seo wrote: > >> remove EXFAT_SB_DIRTY flag and related codes. > >> > >> This flag is set/reset in exfat_put_super()/exfat_sync_fs() to avoid > >> sync_blockdev(). > >> However ... > >> - exfat_put_super(): > >> Before calling this, the VFS has already called sync_fil

Re: [PATCH] exfat: remove EXFAT_SB_DIRTY flag

2020-06-12 Thread Tetsuhiro Kohada
On 2020/06/12 17:34, Sungjong Seo wrote: remove EXFAT_SB_DIRTY flag and related codes. This flag is set/reset in exfat_put_super()/exfat_sync_fs() to avoid sync_blockdev(). However ... - exfat_put_super(): Before calling this, the VFS has already called sync_filesystem(), so sync is never perfor

Re: [PATCH] exfat: remove EXFAT_SB_DIRTY flag

2020-06-12 Thread Greg KH
On Fri, Jun 12, 2020 at 10:48:20AM +0200, Markus Elfring wrote: > > remove EXFAT_SB_DIRTY flag and related codes. > > I suggest to omit this sentence because a similar information > is provided a bit later again for this change description. > > > > If performe 'sync' in this state, VOL_DIRTY wil

Re: [PATCH] exfat: remove EXFAT_SB_DIRTY flag

2020-06-12 Thread Markus Elfring
> remove EXFAT_SB_DIRTY flag and related codes. I suggest to omit this sentence because a similar information is provided a bit later again for this change description. > If performe 'sync' in this state, VOL_DIRTY will not be cleared. Please improve this wording. Would you like to add the ta

RE: [PATCH] exfat: remove EXFAT_SB_DIRTY flag

2020-06-12 Thread Sungjong Seo
> remove EXFAT_SB_DIRTY flag and related codes. > > This flag is set/reset in exfat_put_super()/exfat_sync_fs() to avoid > sync_blockdev(). > However ... > - exfat_put_super(): > Before calling this, the VFS has already called sync_filesystem(), so sync > is never performed here. > - exfat_sync_fs

[PATCH] exfat: remove EXFAT_SB_DIRTY flag

2020-06-11 Thread Tetsuhiro Kohada
remove EXFAT_SB_DIRTY flag and related codes. This flag is set/reset in exfat_put_super()/exfat_sync_fs() to avoid sync_blockdev(). However ... - exfat_put_super(): Before calling this, the VFS has already called sync_filesystem(), so sync is never performed here. - exfat_sync_fs(): After calling