Re: [PATCH] ethernet/arc/arc_emac - Add new driver

2013-06-07 Thread Arnd Bergmann
On Friday 07 June 2013 12:37:24 Alexey Brodkin wrote: > On 06/07/2013 04:13 PM, Arnd Bergmann wrote: > >>> I wonder if it would be better to name the directory "synopsys" or > >>> "designware" rather than "arc" now. Is there a chance that the same > >>> controller is used on non-arc CPUs? > >> > >>

Re: [PATCH] ethernet/arc/arc_emac - Add new driver

2013-06-07 Thread Alexey Brodkin
On 06/07/2013 04:13 PM, Arnd Bergmann wrote: >>> I wonder if it would be better to name the directory "synopsys" or >>> "designware" rather than "arc" now. Is there a chance that the same >>> controller is used on non-arc CPUs? >> >> The thing is - "arc_emac" is a custom ARC's (that was implemented

Re: [PATCH] ethernet/arc/arc_emac - Add new driver

2013-06-07 Thread Arnd Bergmann
On Friday 07 June 2013 10:42:28 Alexey Brodkin wrote: > On 06/07/2013 12:47 PM, Arnd Bergmann wrote: > > I wonder if it would be better to name the directory "synopsys" or > > "designware" rather than "arc" now. Is there a chance that the same > > controller is used on non-arc CPUs? > > The thing

Re: [PATCH] ethernet/arc/arc_emac - Add new driver

2013-06-07 Thread Alexey Brodkin
On 06/07/2013 12:47 PM, Arnd Bergmann wrote: > On Tuesday 04 June 2013 16:21:50 Alexey Brodkin wrote: > >> drivers/net/ethernet/Kconfig |1 + >> drivers/net/ethernet/Makefile|1 + >> drivers/net/ethernet/arc/Kconfig | 29 + >> drivers/net/ethernet/arc/

Re: [PATCH] ethernet/arc/arc_emac - Add new driver

2013-06-07 Thread Arnd Bergmann
On Tuesday 04 June 2013 16:21:50 Alexey Brodkin wrote: > drivers/net/ethernet/Kconfig |1 + > drivers/net/ethernet/Makefile|1 + > drivers/net/ethernet/arc/Kconfig | 29 + > drivers/net/ethernet/arc/Makefile|6 + > drivers/net/ethernet/arc/arc

Re: [PATCH] ethernet/arc/arc_emac - Add new driver

2013-06-06 Thread David Miller
From: Alexey Brodkin Date: Tue, 4 Jun 2013 16:21:50 +0400 > +{ > + struct arc_emac_priv *priv = netdev_priv(net_dev); > + struct phy_device *phydev = priv->phy_dev; > + u32 reg; > + > + int status_change = 0; Do not add empty lines amongst the top-level variable declarations of a

[PATCH] ethernet/arc/arc_emac - Add new driver

2013-06-04 Thread Alexey Brodkin
Driver for non-standard on-chip ethernet device ARC EMAC 10/100, instantiated in some legacy ARC (Synopsys) FPGA Boards such as ARCAngel4/ML50x. This is based off of current Linus tree, build tested for x86. Signed-off-by: Alexey Brodkin Reviewed-by: Vineet Gupta Reviewed-by: Mischa Jonker Cc