Re: [PATCH] esssolo1.c: get rid of check_region

2000-09-29 Thread Alan Cox
> allocated and requested as soon as they are known. Now, that _may_ be at > open() time - there are cards that actually shut down completely and do > not react to IO etc until actually enabled through some magic means (*) > and potentially you could allocate the IO range dynamically at open() tim

Re: [PATCH] esssolo1.c: get rid of check_region

2000-09-29 Thread Linus Torvalds
On Fri, 29 Sep 2000, Alan Cox wrote: > > In solo1_probe, an FM interface is registered. > > > > So, IMHO there is a bug somewhere... Why register an FM interface in > > probe, and then check_region for another FM driver in _open? Is this > > intentional or really a bug? > > The I/O port ran

Re: [PATCH] esssolo1.c: get rid of check_region

2000-09-29 Thread Alan Cox
> In solo1_probe, an FM interface is registered. > > So, IMHO there is a bug somewhere... Why register an FM interface in > probe, and then check_region for another FM driver in _open? Is this > intentional or really a bug? The I/O port range is only activated in open - To unsubscribe from th

Re: [PATCH] esssolo1.c: get rid of check_region

2000-09-29 Thread Jeff Garzik
On Fri, 29 Sep 2000, Alan Cox wrote: > > Thomas, is there a reason for having the OPL3 region check in the > > xxx_open syscall? > The opl3 driver might not have been loaded at init time. esssolo1 does its own FM, so the code in question is attempting to let the driver support either external op

Re: [PATCH] esssolo1.c: get rid of check_region

2000-09-29 Thread Alan Cox
> Thomas, is there a reason for having the OPL3 region check in the > xxx_open syscall? The opl3 driver might not have been loaded at init time. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://w

Re: [PATCH] esssolo1.c: get rid of check_region

2000-09-29 Thread Jeff Garzik
I think we want to move request_region from xxx_open() to the probe stage Thomas, is there a reason for having the OPL3 region check in the xxx_open syscall? Jeff On Tue, 26 Sep 2000, Arnaldo Carvalho de Melo wrote: > Hi, > > Please apply. > > - A

[PATCH] esssolo1.c: get rid of check_region

2000-09-26 Thread Arnaldo Carvalho de Melo
Hi, Please apply. - Arnaldo --- linux-2.4.0-test9-7/drivers/sound/esssolo1.cMon Sep 25 23:31:33 2000 +++ linux-2.4.0-test9-7.acme/drivers/sound/esssolo1.c Tue Sep 26 22:01:17 2000 @@ -2085,12 +2085,11 @@ return -ERESTARTSYS;