Re: [PATCH] efi-pstore: Fix read iter after pstore API refactor

2017-05-19 Thread Ard Biesheuvel
On 18 May 2017 at 17:41, Kees Cook wrote: > On Thu, May 18, 2017 at 9:18 AM, Ard Biesheuvel > wrote: >> On 18 May 2017 at 14:01, Kees Cook wrote: >>> On Thu, May 18, 2017 at 3:35 AM, Ard Biesheuvel >>> wrote: On 12 May 2017 at 22:58, Kees Cook wrote: > During the internal pstore API r

Re: [PATCH] efi-pstore: Fix read iter after pstore API refactor

2017-05-18 Thread Kees Cook
On Thu, May 18, 2017 at 9:18 AM, Ard Biesheuvel wrote: > On 18 May 2017 at 14:01, Kees Cook wrote: >> On Thu, May 18, 2017 at 3:35 AM, Ard Biesheuvel >> wrote: >>> On 12 May 2017 at 22:58, Kees Cook wrote: During the internal pstore API refactoring, the EFI vars read entry was acciden

Re: [PATCH] efi-pstore: Fix read iter after pstore API refactor

2017-05-18 Thread Ard Biesheuvel
On 18 May 2017 at 14:01, Kees Cook wrote: > On Thu, May 18, 2017 at 3:35 AM, Ard Biesheuvel > wrote: >> On 12 May 2017 at 22:58, Kees Cook wrote: >>> During the internal pstore API refactoring, the EFI vars read entry was >>> accidentally made to update a stack variable instead of the pstore >>>

Re: [PATCH] efi-pstore: Fix read iter after pstore API refactor

2017-05-18 Thread Kees Cook
On Thu, May 18, 2017 at 3:35 AM, Ard Biesheuvel wrote: > On 12 May 2017 at 22:58, Kees Cook wrote: >> During the internal pstore API refactoring, the EFI vars read entry was >> accidentally made to update a stack variable instead of the pstore >> private data pointer. This corrects the problem (a

Re: [PATCH] efi-pstore: Fix read iter after pstore API refactor

2017-05-18 Thread Ard Biesheuvel
On 12 May 2017 at 22:58, Kees Cook wrote: > During the internal pstore API refactoring, the EFI vars read entry was > accidentally made to update a stack variable instead of the pstore > private data pointer. This corrects the problem (and removes the now > needless argument). > > Signed-off-by: K

[PATCH] efi-pstore: Fix read iter after pstore API refactor

2017-05-12 Thread Kees Cook
During the internal pstore API refactoring, the EFI vars read entry was accidentally made to update a stack variable instead of the pstore private data pointer. This corrects the problem (and removes the now needless argument). Signed-off-by: Kees Cook --- drivers/firmware/efi/efi-pstore.c | 26