Re: [PATCH] efi: Resolve some shadow warnings

2014-09-06 Thread Jeff Kirsher
On Sat, 2014-09-06 at 10:03 +0100, Matt Fleming wrote: > On Fri, 05 Sep, at 06:34:52PM, Jeff Kirsher wrote: > > From: Mark Rustad > > > > It is a really bad idea to declare variables or parameters that > > have the same name as common types. It is valid C, but it gets > > surprising if a macro ex

Re: [PATCH] efi: Resolve some shadow warnings

2014-09-06 Thread Matt Fleming
On Fri, 05 Sep, at 06:34:52PM, Jeff Kirsher wrote: > From: Mark Rustad > > It is a really bad idea to declare variables or parameters that > have the same name as common types. It is valid C, but it gets > surprising if a macro expansion attempts to declare an inner > local with that type. Change

[PATCH] efi: Resolve some shadow warnings

2014-09-05 Thread Jeff Kirsher
From: Mark Rustad It is a really bad idea to declare variables or parameters that have the same name as common types. It is valid C, but it gets surprising if a macro expansion attempts to declare an inner local with that type. Change the local names to eliminate the hazard. Change s16 => ps16,