Re: [PATCH] efi/libstub: refactor cmd_stubcopy

2019-03-26 Thread Ard Biesheuvel
On Tue, 26 Mar 2019 at 07:06, Masahiro Yamada wrote: > > Hi Ard, > > > > On Sat, Feb 16, 2019 at 11:07 AM Masahiro Yamada > wrote: > > > > On Sat, Feb 16, 2019 at 12:38 AM Ard Biesheuvel > > wrote: > > > > > > On Fri, 15 Feb 2019 at 06:49, Masahiro Yamada > > > wrote: > > > > > > > > On Tue, Fe

Re: [PATCH] efi/libstub: refactor cmd_stubcopy

2019-02-15 Thread Masahiro Yamada
On Sat, Feb 16, 2019 at 12:38 AM Ard Biesheuvel wrote: > > On Fri, 15 Feb 2019 at 06:49, Masahiro Yamada > wrote: > > > > On Tue, Feb 12, 2019 at 4:26 PM Ard Biesheuvel > > wrote: > > > > > > On Tue, 12 Feb 2019 at 04:45, Masahiro Yamada > > > wrote: > > > > > > > > It took me a while to unders

Re: [PATCH] efi/libstub: refactor cmd_stubcopy

2019-02-15 Thread Ard Biesheuvel
On Fri, 15 Feb 2019 at 06:49, Masahiro Yamada wrote: > > On Tue, Feb 12, 2019 at 4:26 PM Ard Biesheuvel > wrote: > > > > On Tue, 12 Feb 2019 at 04:45, Masahiro Yamada > > wrote: > > > > > > It took me a while to understand what is going on in the nested > > > if-blocks. > > > > > > Simplify it b

Re: [PATCH] efi/libstub: refactor cmd_stubcopy

2019-02-14 Thread Masahiro Yamada
On Tue, Feb 12, 2019 at 4:26 PM Ard Biesheuvel wrote: > > On Tue, 12 Feb 2019 at 04:45, Masahiro Yamada > wrote: > > > > It took me a while to understand what is going on in the nested > > if-blocks. > > > > Simplify it by removing unneeded code. > > > > - if_changed automatically adds 'set -e'

Re: [PATCH] efi/libstub: refactor cmd_stubcopy

2019-02-11 Thread Ard Biesheuvel
On Tue, 12 Feb 2019 at 04:45, Masahiro Yamada wrote: > > It took me a while to understand what is going on in the nested > if-blocks. > > Simplify it by removing unneeded code. > > - if_changed automatically adds 'set -e', so any failure in the > series of commands makes it immediately fail

[PATCH] efi/libstub: refactor cmd_stubcopy

2019-02-11 Thread Masahiro Yamada
It took me a while to understand what is going on in the nested if-blocks. Simplify it by removing unneeded code. - if_changed automatically adds 'set -e', so any failure in the series of commands makes it immediately fail as a whole. So, the outer if block is entirely redundant. - S