Re: [PATCH] edac, highbank: remove dependency on ARCH_HIGHBANK

2013-11-11 Thread Rob Herring
On 11/11/2013 05:09 AM, Robert Richter wrote: > On 05.11.13 21:25:52, Rob Herring wrote: >> From: Rob Herring >> >> In order to enable on arm64 and improve the build coverage, remove the >> dependency on ARCH_HIGHBANK. >> >> Signed-off-by: Rob Herring >> Cc: Doug Thompson >> Cc: Robert Richter

Re: [PATCH] edac, highbank: remove dependency on ARCH_HIGHBANK

2013-11-11 Thread Robert Richter
On 05.11.13 21:25:52, Rob Herring wrote: > From: Rob Herring > > In order to enable on arm64 and improve the build coverage, remove the > dependency on ARCH_HIGHBANK. > > Signed-off-by: Rob Herring > Cc: Doug Thompson > Cc: Robert Richter > Cc: linux-e...@vger.kernel.org Rob, I will apply yo

Re: [PATCH] edac, highbank: remove dependency on ARCH_HIGHBANK

2013-11-11 Thread Borislav Petkov
On Mon, Nov 11, 2013 at 11:29:03AM +0100, Robert Richter wrote: > The config option was introduced for this, enable it to be built on > all archs but have an option to disable it on archs where it is not > supposed to run on. I rather prefer COMPILE_TEST. Could we agree on > this? Sure. -- Regar

Re: [PATCH] edac, highbank: remove dependency on ARCH_HIGHBANK

2013-11-11 Thread Robert Richter
On 08.11.13 15:47:21, Borislav Petkov wrote: > > depends on EDAC_MM_EDAC && (ARCH_MULTI_V7 || ARM64 || COMPILE_TEST) > > > > This should enable it with allmodconfig. > > You could do this but the first is already coverage enough IMO and, as I > said previously, compiling this thing on other arch

Re: [PATCH] edac, highbank: remove dependency on ARCH_HIGHBANK

2013-11-08 Thread Borislav Petkov
On Fri, Nov 08, 2013 at 02:59:18PM +0100, Robert Richter wrote: > Can't we just take > > depends on EDAC_MM_EDAC && (ARCH_MULTI_V7 || ARM64) > > as a first step to increase build coverage? Yep, that's basically what I was suggesting. > There is also COMPILE_TEST that could be used which is exact

Re: [PATCH] edac, highbank: remove dependency on ARCH_HIGHBANK

2013-11-08 Thread Robert Richter
On 07.11.13 14:33:29, Borislav Petkov wrote: > On Thu, Nov 07, 2013 at 07:23:10AM -0600, Rob Herring wrote: > > See, we are benefiting already. > > You can catch this when building on arm64, i.e. basically one of the > target architectures for which the driver is meant for. Can't we just take d

Re: [PATCH] edac, highbank: remove dependency on ARCH_HIGHBANK

2013-11-07 Thread Borislav Petkov
On Thu, Nov 07, 2013 at 07:23:10AM -0600, Rob Herring wrote: > See, we are benefiting already. You can catch this when building on arm64, i.e. basically one of the target architectures for which the driver is meant for. -- Regards/Gruss, Boris. -- To unsubscribe from this list: send the line "un

Re: [PATCH] edac, highbank: remove dependency on ARCH_HIGHBANK

2013-11-07 Thread Rob Herring
On 11/07/2013 06:27 AM, Borislav Petkov wrote: > On Wed, Nov 06, 2013 at 11:17:41AM -0600, Rob Herring wrote: >> Using some interface which is arch specific and should not be used in a >> driver. > > Well, sorry, but this is not something which justifies enabling building > of compilation units on

Re: [PATCH] edac, highbank: remove dependency on ARCH_HIGHBANK

2013-11-07 Thread Borislav Petkov
On Wed, Nov 06, 2013 at 11:17:41AM -0600, Rob Herring wrote: > Using some interface which is arch specific and should not be used in a > driver. Well, sorry, but this is not something which justifies enabling building of compilation units on arches for which they don't apply. Rather, this should b

Re: [PATCH] edac, highbank: remove dependency on ARCH_HIGHBANK

2013-11-06 Thread Rob Herring
On 11/06/2013 10:54 AM, Borislav Petkov wrote: > On Wed, Nov 06, 2013 at 10:15:04AM -0600, Rob Herring wrote: >> Other maintainers disagree because it reduces build coverage. > > What possible build coverage are we talking about when building highbank > on x86, for example? And what does a build f

Re: [PATCH] edac, highbank: remove dependency on ARCH_HIGHBANK

2013-11-06 Thread Borislav Petkov
On Wed, Nov 06, 2013 at 10:15:04AM -0600, Rob Herring wrote: > Other maintainers disagree because it reduces build coverage. What possible build coverage are we talking about when building highbank on x86, for example? And what does a build failure in that configuration tell you if it builds and b

Re: [PATCH] edac, highbank: remove dependency on ARCH_HIGHBANK

2013-11-06 Thread Rob Herring
On 11/06/2013 08:20 AM, Borislav Petkov wrote: > On Tue, Nov 05, 2013 at 09:25:52PM -0600, Rob Herring wrote: >> From: Rob Herring >> >> In order to enable on arm64 and improve the build coverage, remove the >> dependency on ARCH_HIGHBANK. >> >> Signed-off-by: Rob Herring >> Cc: Doug Thompson >>

Re: [PATCH] edac, highbank: remove dependency on ARCH_HIGHBANK

2013-11-06 Thread Borislav Petkov
On Tue, Nov 05, 2013 at 09:25:52PM -0600, Rob Herring wrote: > From: Rob Herring > > In order to enable on arm64 and improve the build coverage, remove the > dependency on ARCH_HIGHBANK. > > Signed-off-by: Rob Herring > Cc: Doug Thompson > Cc: Robert Richter > Cc: linux-e...@vger.kernel.org >

[PATCH] edac, highbank: remove dependency on ARCH_HIGHBANK

2013-11-05 Thread Rob Herring
From: Rob Herring In order to enable on arm64 and improve the build coverage, remove the dependency on ARCH_HIGHBANK. Signed-off-by: Rob Herring Cc: Doug Thompson Cc: Robert Richter Cc: linux-e...@vger.kernel.org --- drivers/edac/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions