Re: [PATCH] ecryptfs: remove unneeded buggy code in ecryptfs_do_create()

2014-10-09 Thread Tyler Hicks
Hi Alexey - thanks for the patch. On 2014-09-23 00:39:31, Alexey Khoroshilov wrote: > There is a bug in error handling of lock_parent() in ecryptfs_do_create(): > lock_parent() acquries mutex even if dget_parent() fails, so mutex should be > unlocked anyway. > > But dget_parent() does not fail,

[PATCH] ecryptfs: remove unneeded buggy code in ecryptfs_do_create()

2014-09-22 Thread Alexey Khoroshilov
There is a bug in error handling of lock_parent() in ecryptfs_do_create(): lock_parent() acquries mutex even if dget_parent() fails, so mutex should be unlocked anyway. But dget_parent() does not fail, so the patch just removes unneeded buggy code. Found by Linux Driver Verification project (lin