Re: [PATCH] eCryptfs: Fix dentry handling on create error, unlink, and inode destroy

2008-01-08 Thread Andrew Morton
On Tue, 8 Jan 2008 15:58:07 -0600 Michael Halcrow <[EMAIL PROTECTED]> wrote: > > > rc = ecryptfs_interpose(lower_dentry, ecryptfs_dentry, > > > directory_inode->i_sb, 0); > > > > Will this cause an undesirable log storm if the underlying fs runs > > out of space? > >

Re: [PATCH] eCryptfs: Fix dentry handling on create error, unlink, and inode destroy

2008-01-08 Thread Michael Halcrow
On Mon, Jan 07, 2008 at 09:45:17PM -0800, Andrew Morton wrote: > On Mon, 7 Jan 2008 23:25:42 -0600 Michael Halcrow <[EMAIL PROTECTED]> wrote: > > > --- a/fs/ecryptfs/inode.c > > +++ b/fs/ecryptfs/inode.c > > @@ -120,22 +120,9 @@ ecryptfs_do_create(struct inode *directory_inode, > > rc = ecrypt

Re: [PATCH] eCryptfs: Fix dentry handling on create error, unlink, and inode destroy

2008-01-07 Thread Andrew Morton
On Mon, 7 Jan 2008 23:25:42 -0600 Michael Halcrow <[EMAIL PROTECTED]> wrote: > --- a/fs/ecryptfs/inode.c > +++ b/fs/ecryptfs/inode.c > @@ -120,22 +120,9 @@ ecryptfs_do_create(struct inode *directory_inode, > rc = ecryptfs_create_underlying_file(lower_dir_dentry->d_inode, >

[PATCH] eCryptfs: Fix dentry handling on create error, unlink, and inode destroy

2008-01-07 Thread Michael Halcrow
This patch corrects some erroneous dentry handling in eCryptfs. If there is a problem creating the lower file, then there is nothing that the persistent lower file can do to really help us. This patch makes a vfs_create() failure in the lower filesystem always lead to an unconditional do_create fa