Re: [PATCH] e1000e: fix mismatch in mutex lock-unlock in e1000_reset_hw_82571()

2013-04-18 Thread Jeff Kirsher
On Thu, 2013-04-18 at 22:15 -0700, Alexey Khoroshilov wrote: > If e1000_get_hw_semaphore_82574() succeed, it acquires swflag_mutex, > otherwise it does not. But the returned value of > e1000_get_hw_semaphore_82574() is ignored, so unlocking of > swflag_mutex > happens anyway. > > The patch fixes t

[PATCH] e1000e: fix mismatch in mutex lock-unlock in e1000_reset_hw_82571()

2013-04-18 Thread Alexey Khoroshilov
If e1000_get_hw_semaphore_82574() succeed, it acquires swflag_mutex, otherwise it does not. But the returned value of e1000_get_hw_semaphore_82574() is ignored, so unlocking of swflag_mutex happens anyway. The patch fixes the issue by breaking reset if MIC ownership is not acquired. Found by Linu