Re: [PATCH] dw_dmac: don't exceed AHB master number in dwc_get_data_width

2013-01-15 Thread Andy Shevchenko
On Tue, Jan 15, 2013 at 11:09 AM, Viresh Kumar wrote: > On 15 January 2013 14:38, Andy Shevchenko wrote: >> You forgot the mem2mem type of transfers where we have no information >> about masters except default settings. Otherwise there is the case of >> custom slave config absence when we supply

Re: [PATCH] dw_dmac: don't exceed AHB master number in dwc_get_data_width

2013-01-15 Thread Viresh Kumar
On 15 January 2013 14:38, Andy Shevchenko wrote: > You forgot the mem2mem type of transfers where we have no information > about masters except default settings. Otherwise there is the case of > custom slave config absence when we supply only request line via > slave_id. Okay, but even for mem2me

Re: [PATCH] dw_dmac: don't exceed AHB master number in dwc_get_data_width

2013-01-15 Thread Andy Shevchenko
On Tue, Jan 15, 2013 at 11:01 AM, Viresh Kumar wrote: > On Tue, Jan 15, 2013 at 12:35 PM, Andy Shevchenko > wrote: >>> The details of the patch are fine, but i didn't get how do you get >>> master 1 selected >>> on a system where you have only 1 master? >> >> min_t(..., nr_masters - 1, m) defines

Re: [PATCH] dw_dmac: don't exceed AHB master number in dwc_get_data_width

2013-01-15 Thread Viresh Kumar
On Tue, Jan 15, 2013 at 12:35 PM, Andy Shevchenko wrote: >> The details of the patch are fine, but i didn't get how do you get >> master 1 selected >> on a system where you have only 1 master? > > min_t(..., nr_masters - 1, m) defines this. m is returned value with > default settings, let's say 1.

Re: [PATCH] dw_dmac: don't exceed AHB master number in dwc_get_data_width

2013-01-14 Thread Andy Shevchenko
On Tue, Jan 15, 2013 at 3:54 AM, Viresh Kumar wrote: > On Mon, Jan 14, 2013 at 7:50 PM, Andy Shevchenko > wrote: >> The driver's default assumes that hardware has two AHB masters which might be >> not true. In such rare cases we have not to exceed a number of the AHB >> masters >> present in the

Re: [PATCH] dw_dmac: don't exceed AHB master number in dwc_get_data_width

2013-01-14 Thread Viresh Kumar
On Mon, Jan 14, 2013 at 7:50 PM, Andy Shevchenko wrote: > The driver's default assumes that hardware has two AHB masters which might be > not true. In such rare cases we have not to exceed a number of the AHB masters > present in the hardware. Thus, the AHB master with highest possible number > w

[PATCH] dw_dmac: don't exceed AHB master number in dwc_get_data_width

2013-01-14 Thread Andy Shevchenko
The driver's default assumes that hardware has two AHB masters which might be not true. In such rare cases we have not to exceed a number of the AHB masters present in the hardware. Thus, the AHB master with highest possible number will be used to retrieve the data witdh value. The patch also chan