Re: [PATCH] dt-binding: arm/cpus.txt: fix dynamic-power-coefficient unit

On Tue, 28 Aug 2018 at 16:42, Punit Agrawal wrote: > > Vincent Guittot writes: > > > Hi Amit, > > > > On Wed, 22 Aug 2018 at 12:11, Punit Agrawal wrote: > >> > >> Hi Vincent, > >> > >> Thanks for the patch. One comment about the choice of units below. > >> > >> Vincent Guittot writes: > >> > >>

Re: [PATCH] dt-binding: arm/cpus.txt: fix dynamic-power-coefficient unit

Vincent Guittot writes: > Hi Amit, > > On Wed, 22 Aug 2018 at 12:11, Punit Agrawal wrote: >> >> Hi Vincent, >> >> Thanks for the patch. One comment about the choice of units below. >> >> Vincent Guittot writes: >> >> > The unit of dynamic-power-coefficient is described as mW/MHz/uV^2 whereas >>

Re: [PATCH] dt-binding: arm/cpus.txt: fix dynamic-power-coefficient unit

Hi Amit, On Wed, 22 Aug 2018 at 12:11, Punit Agrawal wrote: > > Hi Vincent, > > Thanks for the patch. One comment about the choice of units below. > > Vincent Guittot writes: > > > The unit of dynamic-power-coefficient is described as mW/MHz/uV^2 whereas > > its usage in the code assumes that un

Re: [PATCH] dt-binding: arm/cpus.txt: fix dynamic-power-coefficient unit

Hi Vincent, Thanks for the patch. One comment about the choice of units below. Vincent Guittot writes: > The unit of dynamic-power-coefficient is described as mW/MHz/uV^2 whereas > its usage in the code assumes that unit is mW/GHz/V^2 Instead of choosing GHz as the base, I'd prefer to use uW/M

[PATCH] dt-binding: arm/cpus.txt: fix dynamic-power-coefficient unit

The unit of dynamic-power-coefficient is described as mW/MHz/uV^2 whereas its usage in the code assumes that unit is mW/GHz/V^2 In drivers/thermal/cpu_cooling.c, the code is : power = (u64)capacitance * freq_mhz * voltage_mv * voltage_mv; do_div(power, 10); which can be summarized as : p