Re: [PATCH] drm/sun4i: move rgb mode_valid from connector to encoder

2018-03-04 Thread Maxime Ripard
On Sun, Mar 04, 2018 at 11:37:50AM +0100, Giulio Benetti wrote: > mode_valid function must be connected to encoder, not connector. > Otherwise it doesn't get called by drm. That's not true, or rather, that's a big oversimplification. It doesn't get called by DRM if you have a bridge instead of a

Re: [PATCH] drm/sun4i: move rgb mode_valid from connector to encoder

2018-03-04 Thread Giulio Benetti
Hello everybody, I wanted to move function sun4i_rgb_encoder_mode_valid from connector section to encoder section. This is why it changes so many things, I don't know if it is the right way to do this. Let me know. Thanks -- Giulio Benetti CTO MICRONOVA SRL Sede: Via A. Niedda 3 - 35010 Vig

[PATCH] drm/sun4i: move rgb mode_valid from connector to encoder

2018-03-04 Thread Giulio Benetti
mode_valid function must be connected to encoder, not connector. Otherwise it doesn't get called by drm. Move mode_valid function pointer to encoder helper functions, changing its prototype according to encoder helper function pointer. Signed-off-by: Giulio Benetti --- drivers/gpu/drm/sun4i/sun