Re: [PATCH] drm/rockchip: get rid of rockchip_drm_crtc_mode_config

2016-04-19 Thread Mark yao
On 2016年04月19日 17:06, John Keeping wrote: On Tue, 19 Apr 2016 10:43:03 +0800, Mark yao wrote: On 2016年04月18日 17:25, John Keeping wrote: On Mon, 18 Apr 2016 11:03:31 +0800, Mark Yao wrote: We need to take care of the vop status when use rockchip_drm_crtc_mode_config, if vop is disabled, the

Re: [PATCH] drm/rockchip: get rid of rockchip_drm_crtc_mode_config

2016-04-19 Thread John Keeping
On Tue, 19 Apr 2016 10:43:03 +0800, Mark yao wrote: > On 2016年04月18日 17:25, John Keeping wrote: > > On Mon, 18 Apr 2016 11:03:31 +0800, Mark Yao wrote: > > > >> >We need to take care of the vop status when use > >> >rockchip_drm_crtc_mode_config, if vop is disabled, > >> >the function would fail

Re: [PATCH] drm/rockchip: get rid of rockchip_drm_crtc_mode_config

2016-04-18 Thread Mark yao
On 2016年04月18日 17:25, John Keeping wrote: On Mon, 18 Apr 2016 11:03:31 +0800, Mark Yao wrote: >We need to take care of the vop status when use >rockchip_drm_crtc_mode_config, if vop is disabled, >the function would failed, that is terrible. > >Save connector type and output mode on drm_display_

Re: [PATCH] drm/rockchip: get rid of rockchip_drm_crtc_mode_config

2016-04-18 Thread Mark yao
On 2016年04月18日 17:25, John Keeping wrote: >We need to take care of the vop status when use >rockchip_drm_crtc_mode_config, if vop is disabled, >the function would failed, that is terrible. > >Save connector type and output mode on drm_display_mode->private_flags >at encoder mode_fixup, then we ca

Re: [PATCH] drm/rockchip: get rid of rockchip_drm_crtc_mode_config

2016-04-18 Thread John Keeping
Hi Mark, On Mon, 18 Apr 2016 11:03:31 +0800, Mark Yao wrote: > We need to take care of the vop status when use > rockchip_drm_crtc_mode_config, if vop is disabled, > the function would failed, that is terrible. > > Save connector type and output mode on drm_display_mode->private_flags > at encod

[PATCH] drm/rockchip: get rid of rockchip_drm_crtc_mode_config

2016-04-17 Thread Mark Yao
We need to take care of the vop status when use rockchip_drm_crtc_mode_config, if vop is disabled, the function would failed, that is terrible. Save connector type and output mode on drm_display_mode->private_flags at encoder mode_fixup, then we can configure the type and mode safely on crtc mode_