Re: [PATCH] drm/komeda: use bitmap API to convert U32 to bitmap

2020-12-29 Thread Yury Norov
On Tue, Dec 29, 2020 at 10:09 AM Yury Norov wrote: > > On Tue, Dec 29, 2020 at 5:50 AM Andy Shevchenko > wrote: > > > > On Tue, Dec 29, 2020 at 2:24 PM Carsten Haitzler > > wrote: > > > > > > On 12/28/20 8:10 PM, Yury Norov wrote: > > > > On Mon, Dec 28, 2020 at 11:49 AM Andy Shevchenko > > > >

Re: [PATCH] drm/komeda: use bitmap API to convert U32 to bitmap

2020-12-29 Thread Yury Norov
On Tue, Dec 29, 2020 at 5:50 AM Andy Shevchenko wrote: > > On Tue, Dec 29, 2020 at 2:24 PM Carsten Haitzler > wrote: > > > > On 12/28/20 8:10 PM, Yury Norov wrote: > > > On Mon, Dec 28, 2020 at 11:49 AM Andy Shevchenko > > > wrote: > > >> On Mon, Dec 28, 2020 at 11:43:43AM -0800, Yury Norov wrot

Re: [PATCH] drm/komeda: use bitmap API to convert U32 to bitmap

2020-12-29 Thread Andy Shevchenko
On Tue, Dec 29, 2020 at 2:24 PM Carsten Haitzler wrote: > > On 12/28/20 8:10 PM, Yury Norov wrote: > > On Mon, Dec 28, 2020 at 11:49 AM Andy Shevchenko > > wrote: > >> On Mon, Dec 28, 2020 at 11:43:43AM -0800, Yury Norov wrote: > >>> The commit be3e477effba636ad25 ("drm/komeda: Fix bit > >>> chec

Re: [PATCH] drm/komeda: use bitmap API to convert U32 to bitmap

2020-12-29 Thread Carsten Haitzler
On 12/28/20 8:10 PM, Yury Norov wrote: > On Mon, Dec 28, 2020 at 11:49 AM Andy Shevchenko > wrote: >> On Mon, Dec 28, 2020 at 11:43:43AM -0800, Yury Norov wrote: >>> The commit be3e477effba636ad25 ("drm/komeda: Fix bit >>> check to import to value of proper type") fixes possible >>> out-of-bound i

Re: [PATCH] drm/komeda: use bitmap API to convert U32 to bitmap

2020-12-28 Thread Andy Shevchenko
On Mon, Dec 28, 2020 at 11:43:43AM -0800, Yury Norov wrote: > The commit be3e477effba636ad25 ("drm/komeda: Fix bit > check to import to value of proper type") fixes possible > out-of-bound issue related to find_first_bit() usage, but > does not address the endianness problem. Hmm... Can you elabor

[PATCH] drm/komeda: use bitmap API to convert U32 to bitmap

2020-12-28 Thread Yury Norov
The commit be3e477effba636ad25 ("drm/komeda: Fix bit check to import to value of proper type") fixes possible out-of-bound issue related to find_first_bit() usage, but does not address the endianness problem. We can use bitmap_from_arr32() here. Since I have no hardware, the patch is compile-test

Re: [PATCH] drm/komeda: use bitmap API to convert U32 to bitmap

2020-12-28 Thread Yury Norov
On Mon, Dec 28, 2020 at 11:49 AM Andy Shevchenko wrote: > > On Mon, Dec 28, 2020 at 11:43:43AM -0800, Yury Norov wrote: > > The commit be3e477effba636ad25 ("drm/komeda: Fix bit > > check to import to value of proper type") fixes possible > > out-of-bound issue related to find_first_bit() usage, bu