Re: [PATCH] drm/i915: Fix refcount leak and possible NULL pointer dereference.

2014-01-06 Thread Daniel Vetter
On Sun, Jan 05, 2014 at 10:08:42AM +0900, Tetsuo Handa wrote: > Chris Wilson wrote: > > > Then, this file->pid in &dev->filelist keeps at least one reference. > > > OK. Updated patch follows. > > > > Looks good to me, and the comment is great. > > -Chris > > Please pick up this patch via your git

Re: [PATCH] drm/i915: Fix refcount leak and possible NULL pointer dereference.

2014-01-04 Thread Tetsuo Handa
Chris Wilson wrote: > > Then, this file->pid in &dev->filelist keeps at least one reference. > > OK. Updated patch follows. > > Looks good to me, and the comment is great. > -Chris Please pick up this patch via your git tree. Also, please change from "" to whatever you like. For example, dump_ho

Re: [PATCH] drm/i915: Fix refcount leak and possible NULL pointer dereference.

2013-12-25 Thread Tetsuo Handa
Hello. Chris Wilson wrote: > > Since get_pid_task() grabs a reference on the task_struct, we have to drop > > the > > refcount after reading that task\'s comm name. Also, directly reading like > > get_pid_task()->comm can trigger an oops when get_pid_task() returned NULL. > > The second issue is

Re: [PATCH] drm/i915: Fix refcount leak and possible NULL pointer dereference.

2013-12-25 Thread Chris Wilson
On Tue, Dec 24, 2013 at 08:50:23PM +0900, Tetsuo Handa wrote: > >From 482be6384379072eb4c0d45d0ab8a25df4f59ed7 Mon Sep 17 00:00:00 2001 > From: Tetsuo Handa > Date: Tue, 24 Dec 2013 18:04:14 +0900 > Subject: [PATCH] drm/i915: Fix refcount leak and possible NULL pointer > deref

[PATCH] drm/i915: Fix refcount leak and possible NULL pointer dereference.

2013-12-24 Thread Tetsuo Handa
>From 482be6384379072eb4c0d45d0ab8a25df4f59ed7 Mon Sep 17 00:00:00 2001 From: Tetsuo Handa Date: Tue, 24 Dec 2013 18:04:14 +0900 Subject: [PATCH] drm/i915: Fix refcount leak and possible NULL pointer dereference. Since get_pid_task() grabs a reference on the task_struct, we have to drop