Re: [PATCH] drm/fb-helper: fix leaks in error path of drm_fb_helper_fbdev_setup

2019-01-08 Thread Noralf Trønnes
Den 05.01.2019 19.25, skrev Noralf Trønnes: > > > Den 24.12.2018 16.03, skrev Peter Wu: >> On Mon, Dec 24, 2018 at 03:52:55PM +0100, Noralf Trønnes wrote: >>> >>> >>> Den 24.12.2018 00.10, skrev Peter Wu: On Sun, Dec 23, 2018 at 02:55:52PM +0100, Noralf Trønnes wrote: > > > De

Re: [PATCH] drm/fb-helper: fix leaks in error path of drm_fb_helper_fbdev_setup

2019-01-05 Thread Noralf Trønnes
Den 24.12.2018 16.03, skrev Peter Wu: On Mon, Dec 24, 2018 at 03:52:55PM +0100, Noralf Trønnes wrote: Den 24.12.2018 00.10, skrev Peter Wu: On Sun, Dec 23, 2018 at 02:55:52PM +0100, Noralf Trønnes wrote: Den 23.12.2018 01.55, skrev Peter Wu: After drm_fb_helper_fbdev_setup calls drm_fb

Re: [PATCH] drm/fb-helper: fix leaks in error path of drm_fb_helper_fbdev_setup

2018-12-24 Thread Peter Wu
On Mon, Dec 24, 2018 at 03:52:55PM +0100, Noralf Trønnes wrote: > > > Den 24.12.2018 00.10, skrev Peter Wu: > > On Sun, Dec 23, 2018 at 02:55:52PM +0100, Noralf Trønnes wrote: > > > > > > > > > Den 23.12.2018 01.55, skrev Peter Wu: > > > > After drm_fb_helper_fbdev_setup calls drm_fb_helper_ini

Re: [PATCH] drm/fb-helper: fix leaks in error path of drm_fb_helper_fbdev_setup

2018-12-24 Thread Noralf Trønnes
Den 24.12.2018 00.10, skrev Peter Wu: On Sun, Dec 23, 2018 at 02:55:52PM +0100, Noralf Trønnes wrote: Den 23.12.2018 01.55, skrev Peter Wu: After drm_fb_helper_fbdev_setup calls drm_fb_helper_init, "dev->fb_helper" will be initialized (and thus drm_fb_helper_fini will have some effect). Af

Re: [PATCH] drm/fb-helper: fix leaks in error path of drm_fb_helper_fbdev_setup

2018-12-23 Thread Peter Wu
On Sun, Dec 23, 2018 at 02:55:52PM +0100, Noralf Trønnes wrote: > > > Den 23.12.2018 01.55, skrev Peter Wu: > > After drm_fb_helper_fbdev_setup calls drm_fb_helper_init, > > "dev->fb_helper" will be initialized (and thus drm_fb_helper_fini will > > have some effect). After that, drm_fb_helper_ini

Re: [PATCH] drm/fb-helper: fix leaks in error path of drm_fb_helper_fbdev_setup

2018-12-23 Thread Noralf Trønnes
Den 23.12.2018 01.55, skrev Peter Wu: After drm_fb_helper_fbdev_setup calls drm_fb_helper_init, "dev->fb_helper" will be initialized (and thus drm_fb_helper_fini will have some effect). After that, drm_fb_helper_initial_config is called which may call the "fb_probe" driver callback. This driv

[PATCH] drm/fb-helper: fix leaks in error path of drm_fb_helper_fbdev_setup

2018-12-22 Thread Peter Wu
After drm_fb_helper_fbdev_setup calls drm_fb_helper_init, "dev->fb_helper" will be initialized (and thus drm_fb_helper_fini will have some effect). After that, drm_fb_helper_initial_config is called which may call the "fb_probe" driver callback. This driver callback may call drm_fb_helper_defio_in