Re: [PATCH] drm/atomic: fix null dereference

2015-07-11 Thread Sudip Mukherjee
On Sat, Jul 11, 2015 at 02:17:49PM -0400, Rob Clark wrote: > On Sat, Jul 11, 2015 at 1:24 PM, Sudip Mukherjee > wrote: > > We are checking the size of e->event but we were doing it when e is > > known to be NULL. > > nak, this will leak event_space.. since it is a sizeof, it isn't > actually der

Re: [PATCH] drm/atomic: fix null dereference

2015-07-11 Thread Rob Clark
On Sat, Jul 11, 2015 at 1:24 PM, Sudip Mukherjee wrote: > We are checking the size of e->event but we were doing it when e is > known to be NULL. nak, this will leak event_space.. since it is a sizeof, it isn't actually deref'ing e, but rather just using the static type info, so it's ok (althoug

[PATCH] drm/atomic: fix null dereference

2015-07-11 Thread Sudip Mukherjee
We are checking the size of e->event but we were doing it when e is known to be NULL. Signed-off-by: Sudip Mukherjee --- drivers/gpu/drm/drm_atomic.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index acebd16..51d3a85 100644 --- a