Re: [PATCH] drm/amd/display: use correct scale for actual_brightness

2020-08-04 Thread Kazlauskas, Nicholas
On 2020-08-04 12:28 p.m., Alexander Monakov wrote: On Tue, 4 Aug 2020, Kazlauskas, Nicholas wrote: This is a cleaner change the other proposed patch since it doesn't need to Can you give a URL to the other patch please? Sorry, replied to the wrong email by accident here. The other change

Re: [PATCH] drm/amd/display: use correct scale for actual_brightness

2020-08-04 Thread Alexander Monakov
On Tue, 4 Aug 2020, Kazlauskas, Nicholas wrote: > This is a cleaner change the other proposed patch since it doesn't need to Can you give a URL to the other patch please? > modify the exist conversion functions but I'd be worried about broken > userspace relying on 0-255 as the only acceptabl

Re: [PATCH] drm/amd/display: use correct scale for actual_brightness

2020-08-04 Thread Kazlauskas, Nicholas
On 2020-08-03 4:02 p.m., Alexander Monakov wrote: Documentation for sysfs backlight level interface requires that values in both 'brightness' and 'actual_brightness' files are interpreted to be in range from 0 to the value given in the 'max_brightness' file. With amdgpu, max_brightness gives 255

Re: [PATCH] drm/amd/display: use correct scale for actual_brightness

2020-08-04 Thread Kazlauskas, Nicholas
This is a cleaner change the other proposed patch since it doesn't need to modify the exist conversion functions but I'd be worried about broken userspace relying on 0-255 as the only acceptable range. Not an expert on existing implementations to point out a specific one though. Regards, Nic

[PATCH] drm/amd/display: use correct scale for actual_brightness

2020-08-03 Thread Alexander Monakov
Documentation for sysfs backlight level interface requires that values in both 'brightness' and 'actual_brightness' files are interpreted to be in range from 0 to the value given in the 'max_brightness' file. With amdgpu, max_brightness gives 255, and values written by the user into 'brightness' a