Re: [PATCH] drivers: net: xgene: Remove acpi_has_method() calls

2019-07-22 Thread David Miller
From: Kelsey Skunberg Date: Sun, 21 Jul 2019 21:04:01 -0600 > + "_RST", NULL, NULL); SPACE before TAB in indentation. > + "_RST", NULL, NULL); ^^ Likewise. G

Re: [PATCH] drivers: net: xgene: Remove acpi_has_method() calls

2019-07-22 Thread kbuild test robot
Hi Kelsey, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.3-rc1 next-20190722] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Kel

[PATCH] drivers: net: xgene: Remove acpi_has_method() calls

2019-07-21 Thread Kelsey Skunberg
acpi_evaluate_object will already return an error if the needed method does not exist. Remove unnecessary acpi_has_method() calls and check the returned acpi_status for failure instead. Signed-off-by: Kelsey Skunberg --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c| 7 +++ drivers/net