Re: [PATCH] drivers: net: ethernet: 3com: fix return value

2016-12-24 Thread Thomas Preisner
On Sat, 2016-12-24 at 02:06 +0100, David Dillow wrote: >On Sat, 2016-12-24 at 00:00 +0100, Thomas Preisner wrote: >> diff --git a/drivers/net/ethernet/3com/typhoon.c >> b/drivers/net/ethernet/3com/typhoon.c >> index a0cacbe..9a3ab58 100644 >> --- a/drivers/net/ethernet/3com/typhoon.c >> +++ b/driv

Re: [PATCH] drivers: net: ethernet: 3com: fix return value

2016-12-23 Thread David Dillow
On Sat, 2016-12-24 at 00:00 +0100, Thomas Preisner wrote: > diff --git a/drivers/net/ethernet/3com/typhoon.c > b/drivers/net/ethernet/3com/typhoon.c > index a0cacbe..9a3ab58 100644 > --- a/drivers/net/ethernet/3com/typhoon.c > +++ b/drivers/net/ethernet/3com/typhoon.c > @@ -2404,6 +2404,7 @@ typho

[PATCH] drivers: net: ethernet: 3com: fix return value

2016-12-23 Thread Thomas Preisner
In a few cases the err-variable is not set to a negative error code if a function call fails and thus 0 is returned instead. It may be better to set err to the proper negative error code before returning. Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188841 Reported-by: Pan Bian Signed-o