Re: [PATCH] drivers/staging/vt6655/iwctl.c fix a sparse warning

2014-04-03 Thread Dan Carpenter
On Thu, Mar 27, 2014 at 08:28:44PM -0700, Jimmy Li wrote: > You are right, I found that variable buf also don't make sense here, > maybe this could be more clear. > > param = kzalloc(sizeof(struct viawget_wpa_param), GFP_KERNEL); > if (param == NULL) > return -ENOMEM; > > removing

Re: [PATCH] drivers/staging/vt6655/iwctl.c fix a sparse warning

2014-03-27 Thread Jimmy Li
On Wed, Mar 26, 2014 at 12:42:43AM -0700, Jimmy Li wrote: > fix a sparse warning. > drivers/staging/vt6655/iwctl.c:1846:35: warning: cast from restricted > gfp_t > drivers/staging/vt6655/iwctl.c:1846:35: warning: incorrect type in > argument 2 (different base types) > drivers/staging/vt6655/iwctl.c

Re: [PATCH] drivers/staging/vt6655/iwctl.c fix a sparse warning

2014-03-26 Thread Joe Perches
On Wed, 2014-03-26 at 00:42 -0700, Jimmy Li wrote: > fix a sparse warning. [] > diff --git a/drivers/staging/vt6655/iwctl.c b/drivers/staging/vt6655/iwctl.c [] > @@ -1843,7 +1843,7 @@ int iwctl_siwencodeext(struct net_device *dev, [] > blen = sizeof(*param); > - buf = kmalloc((int)blen, (

Re: [PATCH] drivers/staging/vt6655/iwctl.c fix a sparse warning

2014-03-26 Thread Greg Kroah-Hartman
On Wed, Mar 26, 2014 at 12:42:43AM -0700, Jimmy Li wrote: > fix a sparse warning. > drivers/staging/vt6655/iwctl.c:1846:35: warning: cast from restricted > gfp_t > drivers/staging/vt6655/iwctl.c:1846:35: warning: incorrect type in > argument 2 (different base types) > drivers/staging/vt6655/iwctl.c

[PATCH] drivers/staging/vt6655/iwctl.c fix a sparse warning

2014-03-26 Thread Jimmy Li
fix a sparse warning. drivers/staging/vt6655/iwctl.c:1846:35: warning: cast from restricted gfp_t drivers/staging/vt6655/iwctl.c:1846:35: warning: incorrect type in argument 2 (different base types) drivers/staging/vt6655/iwctl.c:1846:35:expected restricted gfp_t [usertype] flags drivers/stagin