Re: [PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean

2007-10-30 Thread Richard Knutsson
Matthew Wilcox wrote: On Tue, Oct 30, 2007 at 05:46:08PM +0100, Richard Knutsson wrote: I just don't see the reason why expressing a boolean as an integer. Some advantage? This is C, not Java, or some other highly-typed language. if (int) and if (ptr) are perfectly acceptable in C.

Re: [PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean

2007-10-30 Thread Matthew Wilcox
On Tue, Oct 30, 2007 at 05:46:08PM +0100, Richard Knutsson wrote: > I just don't see the reason why expressing a boolean as an integer. Some > advantage? This is C, not Java, or some other highly-typed language. if (int) and if (ptr) are perfectly acceptable in C. > (also helps us if someone doe

Re: [PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean

2007-10-30 Thread Richard Knutsson
Matthew Wilcox wrote: On Tue, Oct 30, 2007 at 04:02:25PM +0100, Richard Knutsson wrote: Matthew Wilcox wrote: On Tue, Oct 30, 2007 at 11:54:22AM +0100, Richard Knutsson wrote: Convert to use the generic boolean. - u8 initialized; - u8 in_use; /* is the

Re: [PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean

2007-10-30 Thread Matthew Wilcox
On Tue, Oct 30, 2007 at 04:02:25PM +0100, Richard Knutsson wrote: > Matthew Wilcox wrote: > >On Tue, Oct 30, 2007 at 11:54:22AM +0100, Richard Knutsson wrote: > > > >>Convert to use the generic boolean. > >>- u8 initialized; > >>- u8 in_use; /* is the management node open*/ > >>+

Re: [PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean

2007-10-30 Thread Richard Knutsson
Matthew Wilcox wrote: On Tue, Oct 30, 2007 at 11:54:22AM +0100, Richard Knutsson wrote: Convert to use the generic boolean. - u8 initialized; - u8 in_use; /* is the management node open*/ + bool initialized:8; + bool in_use:8; /* is the management

Re: [PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean

2007-10-30 Thread Matthew Wilcox
On Tue, Oct 30, 2007 at 11:54:22AM +0100, Richard Knutsson wrote: > Convert to use the generic boolean. > - u8 initialized; > - u8 in_use; /* is the management node open*/ > + bool initialized:8; > + bool in_use:8; /* is the management node open*/ Are you seri

RE: [PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean

2007-10-30 Thread Salyzyn, Mark
; > Richard Knutsson > Subject: [PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean > > Convert to use the generic boolean. > > Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> > --- > Diffed against linus-git > Checked with script/checkpatch.pl > (warned

[PATCH] drivers/scsi/dpt_i2o: Convert to generic boolean

2007-10-30 Thread Richard Knutsson
Convert to use the generic boolean. Signed-off-by: Richard Knutsson <[EMAIL PROTECTED]> --- Diffed against linus-git Checked with script/checkpatch.pl (warned about long lines, but it is not introduced by this patch) dpt_i2o.c | 22 +++--- dpti.h|9 ++--- 2 files