Re: [PATCH] drivers/rtc/interface.c: check the validation of rtc_time in __rtc_read_time

2014-11-20 Thread Hyogi Gim
On Tue, Oct 14, 2014 at 03:21:31PM -0700, Andrew Morton wrote: > On Wed, 8 Oct 2014 11:05:29 +0900 Hyogi Gim wrote: > > > Some of rtc devices always return '0' when rtc_class_ops.read_time is > > called. > > So if rtc_time isn't verified in callback, rtc interface cannot know whether > > rtc_tim

Re: [PATCH] drivers/rtc/interface.c: check the validation of rtc_time in __rtc_read_time

2014-10-14 Thread Andrew Morton
On Wed, 8 Oct 2014 11:05:29 +0900 Hyogi Gim wrote: > Some of rtc devices always return '0' when rtc_class_ops.read_time is called. > So if rtc_time isn't verified in callback, rtc interface cannot know whether > rtc_time is valid. We should fix the buggy .read_time() implementations... > Check

[PATCH] drivers/rtc/interface.c: check the validation of rtc_time in __rtc_read_time

2014-10-07 Thread Hyogi Gim
Some of rtc devices always return '0' when rtc_class_ops.read_time is called. So if rtc_time isn't verified in callback, rtc interface cannot know whether rtc_time is valid. Check rtc_time by using 'rtc_valid_tm' in '__rtc_read_time'. And add the message for debugging. Signed-off-by: Hyogi Gim -