Re: [PATCH] drivers/platform/x86/dell-rbtn.c - add missing #include

2019-04-05 Thread Andy Shevchenko
On Wed, Mar 13, 2019 at 12:46 AM Pali Rohár wrote: > > On Tuesday 12 March 2019 07:26:06 Valdis Klētnieks wrote: > > Building with W=1 complains: > > CC [M] drivers/platform/x86/dell-rbtn.o > > drivers/platform/x86/dell-rbtn.c:345:5: warning: no previous prototype for > > 'dell_rbtn_notifier_r

Re: [PATCH] drivers/platform/x86/dell-rbtn.c - add missing #include

2019-03-12 Thread valdis . kletnieks
On Tue, 12 Mar 2019 23:46:11 +0100, Pali Rohar said: > Can you identify in which commit was introduced this problem? If yes, > then Fixes: keyword should be added into commit message. I admit not knowing how long that's been there - I mostly found myself with a large amount of free time, a good s

Re: [PATCH] drivers/platform/x86/dell-rbtn.c - add missing #include

2019-03-12 Thread Pali Rohár
On Tuesday 12 March 2019 07:26:06 Valdis Klētnieks wrote: > Building with W=1 complains: > CC [M] drivers/platform/x86/dell-rbtn.o > drivers/platform/x86/dell-rbtn.c:345:5: warning: no previous prototype for > 'dell_rbtn_notifier_register' [-Wmissing-prototypes] > 345 | int dell_rbtn_notifier

[PATCH] drivers/platform/x86/dell-rbtn.c - add missing #include

2019-03-12 Thread Valdis Klētnieks
Building with W=1 complains: CC [M] drivers/platform/x86/dell-rbtn.o drivers/platform/x86/dell-rbtn.c:345:5: warning: no previous prototype for 'dell_rbtn_notifier_register' [-Wmissing-prototypes] 345 | int dell_rbtn_notifier_register(struct notifier_block *nb) | ^~~