Re: [PATCH] drivers/media/video/mx2_emmaprp.c: use devm_kzalloc and devm_clk_get

2012-08-14 Thread Julia Lawall
From: Julia Lawall Using devm_kzalloc simplifies the code and ensures that the use of devm_request_irq is safe. When kzalloc and kfree were used, the interrupt could be triggered after the handler's data argument had been freed. This also introduces some missing initializations of the return va

Re: [PATCH] drivers/media/video/mx2_emmaprp.c: use devm_kzalloc and devm_clk_get

2012-08-14 Thread Mauro Carvalho Chehab
Em 14-08-2012 03:30, Julia Lawall escreveu: >> Well, I've massively applied hundreds of patches today, but not much >> on this driver. Maybe it is better for you to wait for a couple of >> days for these to be at -next, or use, instead, our tree as the basis for >> it: >> git://linuxtv.org/medi

Re: [PATCH] drivers/media/video/mx2_emmaprp.c: use devm_kzalloc and devm_clk_get

2012-08-13 Thread Julia Lawall
Well, I've massively applied hundreds of patches today, but not much on this driver. Maybe it is better for you to wait for a couple of days for these to be at -next, or use, instead, our tree as the basis for it: git://linuxtv.org/media_tree.git staging/for_v3.7 I cloned this, but it do

Re: [PATCH] drivers/media/video/mx2_emmaprp.c: use devm_kzalloc and devm_clk_get

2012-08-13 Thread Mauro Carvalho Chehab
Em 13-08-2012 17:20, Julia Lawall escreveu: > From: Julia Lawall > > Using devm_kzalloc simplifies the code and ensures that the use of > devm_request_irq is safe. When kzalloc and kfree were used, the interrupt > could be triggered after the handler's data argument had been freed. > > This als

Re: [PATCH] drivers/media/video/mx2_emmaprp.c: use devm_kzalloc and devm_clk_get

2012-08-13 Thread Julia Lawall
From: Julia Lawall Using devm_kzalloc simplifies the code and ensures that the use of devm_request_irq is safe. When kzalloc and kfree were used, the interrupt could be triggered after the handler's data argument had been freed. This also introduces some missing initializations of the return v

Re: [PATCH] drivers/media/video/mx2_emmaprp.c: use devm_kzalloc and devm_clk_get

2012-08-13 Thread Julia Lawall
On Mon, 13 Aug 2012, Mauro Carvalho Chehab wrote: Em 10-08-2012 10:59, Julia Lawall escreveu: From: Julia Lawall Using devm_kzalloc and devm_clk_get simplifies the code and ensures that the use of devm_request_irq is safe. When kzalloc and kfree were used, the interrupt could be triggered af

Re: [PATCH] drivers/media/video/mx2_emmaprp.c: use devm_kzalloc and devm_clk_get

2012-08-13 Thread Mauro Carvalho Chehab
Em 10-08-2012 10:59, Julia Lawall escreveu: > From: Julia Lawall > > Using devm_kzalloc and devm_clk_get simplifies the code and ensures that > the use of devm_request_irq is safe. When kzalloc and kfree were used, the > interrupt could be triggered after the handler's data argument had been > f

Re: [PATCH] drivers/media/video/mx2_emmaprp.c: use devm_kzalloc and devm_clk_get

2012-08-10 Thread Julia Lawall
From: Julia Lawall Using devm_kzalloc and devm_clk_get simplifies the code and ensures that the use of devm_request_irq is safe. When kzalloc and kfree were used, the interrupt could be triggered after the handler's data argument had been freed. Add missing return code initializations in the er

Re: [PATCH] drivers/media/video/mx2_emmaprp.c: use devm_kzalloc and devm_clk_get

2012-08-06 Thread Julia . Lawall
Quoting Lars-Peter Clausen : On 08/06/2012 04:26 PM, Dan Carpenter wrote: On Mon, Aug 06, 2012 at 05:23:23PM +0300, Dan Carpenter wrote: On Sat, Aug 04, 2012 at 08:23:27PM +0200, Julia Lawall wrote: @@ -922,12 +920,7 @@ static int emmaprp_probe(struct platform_device *pdev) platfor

Re: [PATCH] drivers/media/video/mx2_emmaprp.c: use devm_kzalloc and devm_clk_get

2012-08-06 Thread Julia . Lawall
Quoting Lars-Peter Clausen : On 08/06/2012 04:26 PM, Dan Carpenter wrote: On Mon, Aug 06, 2012 at 05:23:23PM +0300, Dan Carpenter wrote: On Sat, Aug 04, 2012 at 08:23:27PM +0200, Julia Lawall wrote: @@ -922,12 +920,7 @@ static int emmaprp_probe(struct platform_device *pdev) platfor

Re: [PATCH] drivers/media/video/mx2_emmaprp.c: use devm_kzalloc and devm_clk_get

2012-08-06 Thread Lars-Peter Clausen
On 08/06/2012 04:26 PM, Dan Carpenter wrote: > On Mon, Aug 06, 2012 at 05:23:23PM +0300, Dan Carpenter wrote: >> On Sat, Aug 04, 2012 at 08:23:27PM +0200, Julia Lawall wrote: >>> @@ -922,12 +920,7 @@ static int emmaprp_probe(struct platform_device *pdev) >>> >>> platform_set_drvdata(pdev, pcd

Re: [PATCH] drivers/media/video/mx2_emmaprp.c: use devm_kzalloc and devm_clk_get

2012-08-06 Thread Dan Carpenter
On Mon, Aug 06, 2012 at 05:23:23PM +0300, Dan Carpenter wrote: > On Sat, Aug 04, 2012 at 08:23:27PM +0200, Julia Lawall wrote: > > @@ -922,12 +920,7 @@ static int emmaprp_probe(struct platform_device *pdev) > > > > platform_set_drvdata(pdev, pcdev); > > > > - if (devm_request_mem_region(&

Re: [PATCH] drivers/media/video/mx2_emmaprp.c: use devm_kzalloc and devm_clk_get

2012-08-06 Thread Dan Carpenter
On Sat, Aug 04, 2012 at 08:23:27PM +0200, Julia Lawall wrote: > @@ -922,12 +920,7 @@ static int emmaprp_probe(struct platform_device *pdev) > > platform_set_drvdata(pdev, pcdev); > > - if (devm_request_mem_region(&pdev->dev, res_emma->start, > - resource_size(res_emma), MEM2ME

[PATCH] drivers/media/video/mx2_emmaprp.c: use devm_kzalloc and devm_clk_get

2012-08-04 Thread Julia Lawall
From: Julia Lawall Using devm_kzalloc and devm_clk_get simplifies the code and ensures that the use of devm_request_irq is safe. When kzalloc and kfree were used, the interrupt could be triggered after the handler's data argument had been freed. The problem of a free after a devm_request_irq wa