Re: [PATCH] drivers/dma/sirf-dma.c: fix usage of devm functions

2012-08-21 Thread Julia Lawall
dmaengine: sirf: . That is the usual way, it helps if you see the notation used by subsystem by checking patches being sent to subsystem, but it is not a really big deal, pls take care of this in future. OK. julia -- To unsubscribe from this list: send the line "unsubscribe linux-k

Re: [PATCH] drivers/dma/sirf-dma.c: fix usage of devm functions

2012-08-21 Thread Vinod Koul
On Wed, 2012-08-22 at 13:41 +0800, Barry Song wrote: > >> > >> > >> the git log "drivers/dma/sirf-dma.c: fix usage of devm functions" > >> should be fixed. > > > > > > What do you suggest? The patch is about problems with the use of > > devm_kzalloc, devm_ioremap, and devm_request_irq. > > i mean

Re: [PATCH] drivers/dma/sirf-dma.c: fix usage of devm functions

2012-08-21 Thread Barry Song
2012/8/22 Julia Lawall : > On Wed, 22 Aug 2012, Barry Song wrote: > >> 2012/8/22 Vinod Koul : >>> >>> On Sat, 2012-08-04 at 10:35 +0200, Julia Lawall wrote: From: Julia Lawall Fix some problems with the use of devm_ functions. >>> >>> Applied, thanks >> >> >> the git log "drive

Re: [PATCH] drivers/dma/sirf-dma.c: fix usage of devm functions

2012-08-21 Thread Julia Lawall
On Wed, 22 Aug 2012, Barry Song wrote: 2012/8/22 Vinod Koul : On Sat, 2012-08-04 at 10:35 +0200, Julia Lawall wrote: From: Julia Lawall Fix some problems with the use of devm_ functions. Applied, thanks the git log "drivers/dma/sirf-dma.c: fix usage of devm functions" should be fixed. W

Re: [PATCH] drivers/dma/sirf-dma.c: fix usage of devm functions

2012-08-21 Thread Barry Song
2012/8/22 Vinod Koul : > On Sat, 2012-08-04 at 10:35 +0200, Julia Lawall wrote: >> From: Julia Lawall >> >> Fix some problems with the use of devm_ functions. > Applied, thanks the git log "drivers/dma/sirf-dma.c: fix usage of devm functions" should be fixed. > > > -- > ~Vinod > -barry -- To un

Re: [PATCH] drivers/dma/sirf-dma.c: fix usage of devm functions

2012-08-21 Thread Vinod Koul
On Sat, 2012-08-04 at 10:35 +0200, Julia Lawall wrote: > From: Julia Lawall > > Fix some problems with the use of devm_ functions. Applied, thanks -- ~Vinod -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More ma

Re: [PATCH] drivers/dma/sirf-dma.c: fix usage of devm functions

2012-08-04 Thread Barry Song
2012/8/4 Julia Lawall > > From: Julia Lawall > > Fix some problems with the use of devm_ functions. > > devm_kzalloc: devm_kfree is not needed > > devm_ioremap: iounmap should not be used, no free is needed > > devm_request_irq: the devm_free_irq is followed by irq_dispose_mapping. I > don't kno

[PATCH] drivers/dma/sirf-dma.c: fix usage of devm functions

2012-08-04 Thread Julia Lawall
From: Julia Lawall Fix some problems with the use of devm_ functions. devm_kzalloc: devm_kfree is not needed devm_ioremap: iounmap should not be used, no free is needed devm_request_irq: the devm_free_irq is followed by irq_dispose_mapping. I don't know if it is safe to move the freeing of th