Re: [PATCH] drivers/char/serial.c bug in ST16C654 detection

2001-05-17 Thread Theodore Tso
On Wed, May 16, 2001 at 04:12:45PM -0600, Val Henson wrote: > Anyone know where Ted Tso is? He hasn't posted in several weeks. > Alan, will you put this in -ac? This patch fixes a bug in serial.c > that causes a crash on machines with a ST16C654. I'm around, just swamped with a few other things

Re: [PATCH] drivers/char/serial.c bug in ST16C654 detection

2001-05-17 Thread Val Henson
On Thu, May 17, 2001 at 09:49:11AM -0400, Stuart MacDonald wrote: > Are you using the serial console though? That seems to be > implied by your problem, but I just want to check. Yes, I have serial console only on this board. -VAL - To unsubscribe from this list: send the line "unsubscribe linu

Re: [PATCH] drivers/char/serial.c bug in ST16C654 detection

2001-05-17 Thread Stuart MacDonald
From: "Val Henson" <[EMAIL PROTECTED]> > Anyone know where Ted Tso is? He hasn't posted in several weeks. Haven't heard from him in a while. I've got a patch or two pending as well, one of which modifies this code to check for 16c2850s. Usually he just says he's really busy. > > Kernel version?

Re: [PATCH] drivers/char/serial.c bug in ST16C654 detection

2001-05-16 Thread Val Henson
Anyone know where Ted Tso is? He hasn't posted in several weeks. Alan, will you put this in -ac? This patch fixes a bug in serial.c that causes a crash on machines with a ST16C654. On Tue, May 15, 2001 at 09:52:01AM -0400, Stuart MacDonald wrote: > Kernel version? Distribution? Are you using a

Re: [PATCH] drivers/char/serial.c bug in ST16C654 detection

2001-05-15 Thread Stuart MacDonald
From: "Val Henson" <[EMAIL PROTECTED]> > Serial driver version 5.05a (2001-03-20) with MANY_PORTS SHARE_IRQ > SERIAL_PCI enabled Hmm. I've been looking at 5.05 (from http://serial.sourceforge.net), I'm getting 2.4.4 and 2.4.5-pre2 to see what's in there. > "Go kablooey" means that all serial out

Re: [PATCH] drivers/char/serial.c bug in ST16C654 detection

2001-05-14 Thread Val Henson
On Mon, May 14, 2001 at 03:50:01PM -0400, Stuart MacDonald wrote: > What version of serial.c? I'm assuming 5.05. Serial driver version 5.05a (2001-03-20) with MANY_PORTS SHARE_IRQ SERIAL_PCI enabled > Define "go kablooey". We haven't noticed any problems, and we supplied > this bit of code. "G

Re: [PATCH] drivers/char/serial.c bug in ST16C654 detection

2001-05-14 Thread Stuart MacDonald
From: "Val Henson" <[EMAIL PROTECTED]> > This fixes a bug in the autoconfig_startech_uarts function in > serial.c. The problem is that 0's are written to the baud rate > registers in order to detect an XR16C850 or XR16C854. This makes the > Exar ST16C654 go kablooey. Saving and restoring the ba

[PATCH] drivers/char/serial.c bug in ST16C654 detection

2001-05-11 Thread Val Henson
This fixes a bug in the autoconfig_startech_uarts function in serial.c. The problem is that 0's are written to the baud rate registers in order to detect an XR16C850 or XR16C854. This makes the Exar ST16C654 go kablooey. Saving and restoring the baud rate registers after the test fixes it. I'm