Re: [PATCH] drivers/ata: print trim features at device initialization

2019-06-14 Thread James Bottomley
On Fri, 2019-06-14 at 16:49 +0300, Konstantin Khlebnikov wrote: > > On 11.06.2019 1:48, James Bottomley wrote: > > On Mon, 2019-06-10 at 10:49 +0300, Konstantin Khlebnikov wrote: > > > On 10.06.2019 0:37, James Bottomley wrote: > > > > On Sat, 2019-06-08 at 17:13 +0300, Konstantin Khlebnikov wrote

Re: [PATCH] drivers/ata: print trim features at device initialization

2019-06-14 Thread Konstantin Khlebnikov
On 11.06.2019 1:48, James Bottomley wrote: On Mon, 2019-06-10 at 10:49 +0300, Konstantin Khlebnikov wrote: On 10.06.2019 0:37, James Bottomley wrote: On Sat, 2019-06-08 at 17:13 +0300, Konstantin Khlebnikov wrote: On 08.06.2019 11:25, Christoph Hellwig wrote:> On Fri, Jun 07, 2019 at 10:34:

Re: [PATCH] drivers/ata: print trim features at device initialization

2019-06-10 Thread James Bottomley
On Mon, 2019-06-10 at 10:49 +0300, Konstantin Khlebnikov wrote: > On 10.06.2019 0:37, James Bottomley wrote: > > On Sat, 2019-06-08 at 17:13 +0300, Konstantin Khlebnikov wrote: > > > > On 08.06.2019 11:25, Christoph Hellwig wrote:> On Fri, Jun 07, > > > > 2019 > > > > at 10:34:39AM +0300, Konstanti

Re: [PATCH] drivers/ata: print trim features at device initialization

2019-06-10 Thread Konstantin Khlebnikov
On 10.06.2019 0:37, James Bottomley wrote: On Sat, 2019-06-08 at 17:13 +0300, Konstantin Khlebnikov wrote: On 08.06.2019 11:25, Christoph Hellwig wrote:> On Fri, Jun 07, 2019 at 10:34:39AM +0300, Konstantin Khlebnikov wrote: > > Do we really need to spam dmesg with even more ATA crap? What

Re: [PATCH] drivers/ata: print trim features at device initialization

2019-06-09 Thread James Bottomley
On Sat, 2019-06-08 at 17:13 +0300, Konstantin Khlebnikov wrote: > > On 08.06.2019 11:25, Christoph Hellwig wrote:> On Fri, Jun 07, 2019 > > at 10:34:39AM +0300, Konstantin Khlebnikov wrote: > > > > > > Do we really need to spam dmesg with even more ATA crap? What > > about > > > a sysfs file th

Re: [PATCH] drivers/ata: print trim features at device initialization

2019-06-08 Thread Konstantin Khlebnikov
On 08.06.2019 12:12, Konstantin Khlebnikov wrote: On 07.06.2019 19:58, Martin K. Petersen wrote: Konstantin, +    if (dev->horkage & ATA_HORKAGE_NOTRIM) +    trim_status = "backlisted"; blacklisted Oops. My bad. +    else +    trim_status = "

Re: [PATCH] drivers/ata: print trim features at device initialization

2019-06-08 Thread Konstantin Khlebnikov
On 07.06.2019 19:58, Martin K. Petersen wrote: Konstantin, + if (dev->horkage & ATA_HORKAGE_NOTRIM) + trim_status = "backlisted"; blacklisted Oops. My bad. + else + trim_status = "su

Re: [PATCH] drivers/ata: print trim features at device initialization

2019-06-08 Thread Christoph Hellwig
On Fri, Jun 07, 2019 at 10:34:39AM +0300, Konstantin Khlebnikov wrote: > Print trim status once at ata device initialization in form: Do we really need to spam dmesg with even more ATA crap? What about a sysfs file that can be read on demand instead?

Re: [PATCH] drivers/ata: print trim features at device initialization

2019-06-07 Thread Martin K. Petersen
Konstantin, > + if (dev->horkage & ATA_HORKAGE_NOTRIM) > + trim_status = "backlisted"; blacklisted > + else > + trim_status = "supported"; > + > + if (!ata_fpdma_dsm_supported(de

[PATCH] drivers/ata: print trim features at device initialization

2019-06-07 Thread Konstantin Khlebnikov
Print trim status once at ata device initialization in form: ataX.YZ: trim: , queued: , zero_after_trim: Full example: ata1: SATA link up 6.0 Gbps (SStatus 133 SControl 300) ata1.00: NCQ Send/Recv Log not supported ata1.00: ATA-9: SAMSUNG MZ7GE900HMHP-000DX, EXT03Y3Q, max UDMA/133 ata1