Re: [PATCH] driver/rtc/class.c: check the error after rtc_read_time()

2014-08-06 Thread Hyogi Gim
On 07/24/2014 09:19 AM, Andrew Morton wrote: > > So what should rtc do in this case? At present it pretends the read > succeeded. Either way, this doesn't seem to be the place to be making > such policy decisions.. > > > I agree. But, in this case, RTC device driver can not do anything. An

Re: [PATCH] driver/rtc/class.c: check the error after rtc_read_time()

2014-07-23 Thread Andrew Morton
On Thu, 24 Jul 2014 01:49:44 +0200 "Rafael J. Wysocki" wrote: > On Thursday, July 24, 2014 01:47:57 AM Rafael J. Wysocki wrote: > > On Wednesday, July 23, 2014 02:56:34 PM Andrew Morton wrote: > > > On Tue, 15 Jul 2014 17:25:23 +0900 Hyogi Gim wrote: > > > > > > > In rtc_suspend() and rtc_resu

Re: [PATCH] driver/rtc/class.c: check the error after rtc_read_time()

2014-07-23 Thread Rafael J. Wysocki
On Thursday, July 24, 2014 01:47:57 AM Rafael J. Wysocki wrote: > On Wednesday, July 23, 2014 02:56:34 PM Andrew Morton wrote: > > On Tue, 15 Jul 2014 17:25:23 +0900 Hyogi Gim wrote: > > > > > In rtc_suspend() and rtc_resume(), the error after rtc_read_time() is not > > > checked. If rtc device f

Re: [PATCH] driver/rtc/class.c: check the error after rtc_read_time()

2014-07-23 Thread Rafael J. Wysocki
On Wednesday, July 23, 2014 02:56:34 PM Andrew Morton wrote: > On Tue, 15 Jul 2014 17:25:23 +0900 Hyogi Gim wrote: > > > In rtc_suspend() and rtc_resume(), the error after rtc_read_time() is not > > checked. If rtc device fail to read time, we cannot guarantee the following > > process. > > > >

Re: [PATCH] driver/rtc/class.c: check the error after rtc_read_time()

2014-07-23 Thread Andrew Morton
On Tue, 15 Jul 2014 17:25:23 +0900 Hyogi Gim wrote: > In rtc_suspend() and rtc_resume(), the error after rtc_read_time() is not > checked. If rtc device fail to read time, we cannot guarantee the following > process. > > Add the verification code for returned rtc_read_time() error. > > ... > >

[PATCH] driver/rtc/class.c: check the error after rtc_read_time()

2014-07-15 Thread Hyogi Gim
In rtc_suspend() and rtc_resume(), the error after rtc_read_time() is not checked. If rtc device fail to read time, we cannot guarantee the following process. Add the verification code for returned rtc_read_time() error. Signed-off-by: Hyogi Gim --- drivers/rtc/class.c | 16 ++-- 1